Differential D15152
GHOST/Wayland support for tablet events Authored by Campbell Barton (campbellbarton) on Jun 8 2022, 4:04 PM. Tags Subscribers None Tokens
Details Add support for tablet pressure, tilt and type detection (eraser, pen.. etc). There is currently an inconsistency where the tablets cursor is scaled larger than the mouse cursor (when the UI is scaled). Otherwise the basics are working, I'd like to be sure this isn't causing build issues on other peoples systems as I'm not sure how widely supported the tablet protocol is.
Diff Detail
Event TimelineComment Actions Move additional data about the tablets state (it's tool & cursor) into it's Comment Actions Move the tablet data from the window into the tool, Comment Actions Is this tablet interface also supposed to work on touch screens (e.g. on laptops with touch screens or tablet devices without keyboards) or does this only work for "drawing tablets" that use a pen as input?
Comment Actions From checking the docs, this is handled separately, touch has it's own section in https://wayland-book.com/seat.html
Comment Actions Committing this without review as I was mostly concerned using a newer tablet API might cause build issues. As this isn't on by default and doesn't change library linking - this doesn't seem likely. Comment Actions (I received an email with a comment "do you see any issues with this patch" that I cannot find here.) The changes are fine. I don't have the hardware to test this. My only concern was about the "magic numbers". But I see that I also added those kinds of defines myself for the mouse buttons. I now remember that we did this because one of the Linux headers (I think linux/input-event-codes.h) was either not available or just did not contain those defines on CentOS 7. To check build failures, I think it would be a good idea to add a "Wayland" build task on the build server to make sure that the Wayland implementation does not break over time. | ||||||||||||||||