Page MenuHome
Differential D15158

Remove unnecessary transpose when using `mat3_from_axis_conversion`
ClosedPublic
Actions

Authored by Iyad Ahmed (iyadahmed2001) on Jun 9 2022, 2:44 PM.

Details

Reviewers
Gaia Clary (gaiaclary)
Howard Trickey (howardt)
Aras Pranckevicius (aras_p)
Bastien Montagne (mont29)
Commits
rB280449731235: io: remove unnecessary transposes when using mat3_from_axis_conversion

Diff Detail

Repository
rB Blender

Event Timeline

Iyad Ahmed (iyadahmed2001) requested review of this revision.Jun 9 2022, 2:44 PM
Iyad Ahmed (iyadahmed2001) created this revision.
Iyad Ahmed (iyadahmed2001) added a reviewer: Aras Pranckevicius (aras_p).Jun 9 2022, 3:12 PM
Aras Pranckevicius (aras_p) accepted this revision.Jun 9 2022, 3:45 PM
This revision is now accepted and ready to land.Jun 9 2022, 3:45 PM
Iyad Ahmed (iyadahmed2001) added a comment.EditedJun 10 2022, 2:58 PM

btw can we get this committed?
it passes the tests and I can confirm it indeed works, it is like this in the STL importer too
@Aras Pranckevicius (aras_p)

Edit: Ok, we should wait until all reviewers accept it, or at least more reviewers

Iyad Ahmed (iyadahmed2001) added a reviewer: Bastien Montagne (mont29).Jun 14 2022, 7:40 AM

I included Bastien as a reviewer in case the other reviewers are unavailable, this week many people are away, I should wait

Closed by commit rB280449731235: io: remove unnecessary transposes when using mat3_from_axis_conversion (authored by Iyad Ahmed (iyadahmed2001), committed by Aras Pranckevicius (aras_p)). · Explain WhyJun 15 2022, 8:47 PM
This revision was automatically updated to reflect the committed changes.
Aras Pranckevicius (aras_p) added a commit: rB280449731235: io: remove unnecessary transposes when using mat3_from_axis_conversion.

Revision Contents
Changeset List

PathSize
source/
blender/
io/
collada/
6 lines
wavefront_obj/
exporter/
4 lines
4 lines
importer/
4 lines

Diff 52554

View Options

source/blender/io/collada/BCMath.cpp

Loading...
View Options

source/blender/io/wavefront_obj/exporter/obj_export_mesh.cc

Loading...
View Options

source/blender/io/wavefront_obj/exporter/obj_export_nurbs.cc

Loading...
View Options

source/blender/io/wavefront_obj/importer/importer_mesh_utils.cc

Loading...