Cycles: MetalDeviceQueue - capture of multiple dispatches, and some tidying
ClosedPublic
Actions

Authored by Michael Jones (michael_jones) on Jun 13 2022, 12:55 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Commits

rB19e0b60f3e12: Cycles: MetalDeviceQueue - capture of multiple dispatches, and some tidying

Summary

This patch adds a new mode of gpu capture (env var CYCLES_DEBUG_METAL_CAPTURE_SAMPLES) to capture a block of dispatches between "reset" calls. It also fixes member data naming inconsistencies and adds some missing OS version checks.

Screenshot showing .gputrace capture in Xcode 14.0 beta (using CYCLES_DEBUG_METAL_CAPTURE_SAMPLES="1" and CYCLES_DEBUG_METAL_CAPTURE_LIMIT="10"):

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 22507
Build 22507: arc lint + arc unit

Event Timeline

Michael Jones (michael_jones) requested review of this revision.Jun 13 2022, 12:55 PM

Michael Jones (michael_jones) created this revision.

Harbormaster completed remote builds in B22506: Diff 52463.Jun 13 2022, 12:55 PM

Michael Jones (michael_jones) edited the summary of this revision. (Show Details)Jun 13 2022, 1:08 PM

Looks good overall, just this warning when compiling for x86_64 still:

/Users/blender/git/blender-vdev/blender.git/intern/cycles/device/metal/queue.mm:315:7: warning: 'timing_shared_event_' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/Users/blender/git/blender-vdev/blender.git/intern/cycles/device/metal/queue.mm:403:27: warning: 'timing_shared_event_' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]
/Users/blender/git/blender-vdev/blender.git/intern/cycles/device/metal/queue.mm:819:7: warning: 'timing_shared_event_' is only available on macOS 10.14 or newer [-Wunguarded-availability-new]

This revision now requires changes to proceed.Jun 13 2022, 1:22 PM

Michael Jones (michael_jones) mentioned this in rB4412e14708c5: Cycles: Useful Metal backend debug & profiling functionality.Jun 13 2022, 1:26 PM