Fix T98765: Regression: Unable to select mask points in clip editor
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jun 13 2022, 4:25 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T98765: Regression: Unable to select mask points in clip editor

Commits

rB7ff5f9565781: Fix T98765: Regression: Unable to select mask points in clip editor
rBea39d808b516: Fix T98765: Regression: Unable to select mask points in clip editor

Summary

Re-organize de-selection so that there is less conflict between tracking
and masking operators.

Still not fully ideal: the LMB selection does not de-select everything
now since the mask.select with deselect_all is only added to the
keymap when the RMB is the select mouse. While this is sub-optimal, this
seems to be how mask selection behaved in the Image Editor in 3.1.

Not sure it worth looking into a more complete fix, as it will likely be
too big to be safe for a corrective release.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Jun 13 2022, 4:25 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B22509: Diff 52473.Jun 13 2022, 4:25 PM

Sergey Sharybin (sergey) added a task: T98765: Regression: Unable to select mask points in clip editor.Jun 13 2022, 4:26 PM

This seems OK. Looked into details and any other solution is likely much more involved.

It's important the select operator uses pass-through so drag event is generated.
If the select event passes through then the clip selection runs too.

We'll either need a single selection operator to properly handle this, or a way to differentiate which operator should run (instead of running both on the same key-binding).

This revision is now accepted and ready to land.Jun 14 2022, 10:07 AM

Closed by commit rBea39d808b516: Fix T98765: Regression: Unable to select mask points in clip editor (authored by Sergey Sharybin (sergey)). · Explain WhyJun 15 2022, 10:24 AM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rBea39d808b516: Fix T98765: Regression: Unable to select mask points in clip editor.

Philipp Oeser (lichtwerk) added a commit: rB7ff5f9565781: Fix T98765: Regression: Unable to select mask points in clip editor.Jun 22 2022, 1:03 PM