Automated testing: Add operators tests
ClosedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Jun 13 2022, 8:23 PM.

Details

Reviewers

Himanshi Kalra (calra)
Habib Gahbiche (zazizizou)
Bastien Montagne (mont29)

Commits

rB074ce49de014: Automated testing: Add operators tests

Summary

Part of T84999: Add Operator tests
This patch adds test for

dissolve_limited
dissolve_mode
merge_normals

Updated blend file:

operators.blend3 MBDownload

Diff Detail

Repository: rB Blender

Event Timeline

Hi. let me know if I've done this correctly. Will add more test further.

Pratik Borhade (PratikPB2123) mentioned this in T84999: Add Operator tests.Jun 13 2022, 8:32 PM

adds test for Limited dissolve operator

Pratik Borhade (PratikPB2123) retitled this revision from Automated testing: Add Merge normal test to Automated testing: Add operators tests.Jun 14 2022, 2:15 PM

Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)

Pratik Borhade (PratikPB2123) removed a project: Platforms, Builds, Tests & Devices.Jun 14 2022, 2:57 PM

Pratik Borhade (PratikPB2123) updated this revision to Diff 52495.Jun 14 2022, 2:59 PM

Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)

Kevin Curry (KevinCurry_Unity) added a subscriber: Kevin Curry (KevinCurry_Unity).Jun 14 2022, 6:19 PM

Paul Kotelevets (1D_Inc) awarded a token.Jun 15 2022, 12:12 AM

I ran several tests and looked at the blend file. It all looks good to me, thank you for the patch!

P.s. remember to submit the blend file first so that tests don't fail on buildbot

This revision is now accepted and ready to land.Jun 16 2022, 12:32 PM

@Habib Gahbiche (zazizizou) hi and thanks for reviewing the patch

I ran several tests

May I know what types of different tests you used to test this patch? So that I can run them too.

P.s. remember to submit the blend file first so that tests don't fail on buildbot

I don't have commit rights so could you do that for me? :)

In D15187#410368, @Pratik Borhade (PratikPB2123) wrote:

May I know what types of different tests you used to test this patch? So that I can run them too.

made sure tests can fail by changing parameters in code, and geometry in blend file
made sure other tests were not accidentally updated / messed up by running current tests with new blend file.
looked at naming, style and parameter choice

Adding Bastien as blocking reviewer since final approval should come from module owner. I can commit the patch once approved by Bastien.

This revision now requires review to proceed.Jun 19 2022, 1:54 PM

LGTM, will add the updated testfile to SVN, thanks!

This revision is now accepted and ready to land.Jul 6 2022, 4:05 PM

Bastien Montagne (mont29) mentioned this in rBL62968: Updated blend file for 'operators' test..Jul 6 2022, 4:07 PM