Page MenuHome

Spreadsheet: Support operations for filtering colors
ClosedPublic

Authored by Angel Bueno (angelbpineda) on Jun 14 2022, 3:36 PM.

Details

Summary

Support choosing an operation when filtering colors, like the other types.

Diff Detail

Repository
rB Blender

Event Timeline

Angel Bueno (angelbpineda) requested review of this revision.Jun 14 2022, 3:36 PM
Angel Bueno (angelbpineda) created this revision.
Angel Bueno (angelbpineda) created this object with visibility "All Users".
Angel Bueno (angelbpineda) created this object with edit policy "Administrators".
Dalai Felinto (dfelinto) changed the visibility from "All Users" to "Public (No Login Required)".Jun 14 2022, 3:42 PM
Dalai Felinto (dfelinto) changed the edit policy from "Administrators" to "Moderators (Project)".

Hi, it is working fine, great job.

One thing that I miss is to have the range defined so that we are restrict to 0.0 to 1.0 values. I think it is fine to use full floats as hard range, but for the soft range 0.0 to 1.0 makes more sense. (e.g., 0b38b8dafaa2).

The problem with that is that it makes more complicated to use the "Less Than" range. For instance, the Alpha is often 1.0. In this case for me to filter out any color I need to use "Less Than" 1.1. So maybe it is fine to leave the patch as it is.

For the records, this is my test file:

Angel Bueno (angelbpineda) retitled this revision from SpreadSheet to SpreadSheet: Filter Col (color attribute).Jun 14 2022, 5:29 PM

If it's working well in Dalai's tests, the code looks good to me. I'd suggest changing the commit message and description a bit though, something like this:

Spreadsheet: Support operations for filtering colors

Support choosing an operation when filtering colors, like the other types.
...
This revision is now accepted and ready to land.Jun 14 2022, 5:33 PM

Thank you! I've noticed about this, I've fixed this by changing "<" and ">" to "<=" and ">=", and it works fine.

Angel Bueno (angelbpineda) retitled this revision from SpreadSheet: Filter Col (color attribute) to Spreadsheet: Support operations for filtering colors.Jun 14 2022, 8:08 PM
Angel Bueno (angelbpineda) edited the summary of this revision. (Show Details)