Differential D15241

Fix T94969: Crash. Volume to mesh with 0 amount of voxels
ClosedPublic
Actions

Authored by Erik Abrahamsson (erik85) on Jun 19 2022, 10:41 PM.

Tags

Subscribers

Pratik Borhade (PratikPB2123)

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T94969: Crash. Volume to mesh with 0 amount of voxels

Commits

rB6d196b8f5e95: Fix T94969: Crash in Volume to Mesh with 0 voxels
rB522dcc54af35: Fix T94969: Crash in Volume to Mesh with 0 voxels

Summary

Fix for T94969.
Don't try to create a mesh from the volume is voxel amount or size is <= 0.
Similar check is already in the Volume to Mesh modifier.

Diff Detail

Repository: rB Blender

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Jun 19 2022, 10:41 PM

Erik Abrahamsson (erik85) created this revision.

Erik Abrahamsson (erik85) edited the summary of this revision. (Show Details)

Looks good, but I think the node can just return null in this case, there is no need to return an empty mesh.

I'll accept anyway though, since that's a simple change.

This revision is now accepted and ready to land.Jun 20 2022, 7:19 PM

Closed by commit rB522dcc54af35: Fix T94969: Crash in Volume to Mesh with 0 voxels (authored by Erik Abrahamsson (erik85)). · Explain WhyJun 20 2022, 8:14 PM

This revision was automatically updated to reflect the committed changes.

Erik Abrahamsson (erik85) added a commit: rB522dcc54af35: Fix T94969: Crash in Volume to Mesh with 0 voxels.

Fine if I mention this fix for corrective release?

Thomas Dinges (dingto) added a commit: rB6d196b8f5e95: Fix T94969: Crash in Volume to Mesh with 0 voxels.Jun 24 2022, 10:43 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_volume_to_mesh.cc

10 lines

Diff 52700

source/blender/nodes/geometry/nodes/node_geo_volume_to_mesh.cc

Loading...