Page MenuHome

Fix T98960: Baking to active color attribute uses wrong layer
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jun 20 2022, 7:39 PM.

Details

Summary

Baking assumed that color attributes could only have two configurations:
float color data type on vertices, or byte color type on face corners.
In reality the options can be combined to make four total options.
This commit handles the four cases explicitly with a somewhat
more scaleable approach (though this should really be C++ code).

This commit also changes some related error messages, tooltips,
and an enum name, in order to make the functionality more obvious.


A version of this change without the UI text changes can be committed to 3.2.

Diff Detail

Repository
rB Blender

Event Timeline

Looks good to me, assuming you agree that code should be removed.

source/blender/editors/object/object_bake_api.c
450–457

Remove this CustomData_get_layer code, it doesn't do anything.

This revision is now accepted and ready to land.Jun 21 2022, 4:11 PM
Hans Goudey (HooglyBoogly) marked an inline comment as done.Jun 21 2022, 9:19 PM