Icons: Add each icon to a named group
ClosedPublic
Actions

Authored by Francesco Siddi (fsiddi) on Jun 21 2022, 2:07 PM.

Details

Reviewers

Commits

rB8ea5a5259d2c: Icons: Add each icon to a named group

Summary

The objects making up each icon are placed in a group named after the icon coordinates in the grid. This change has no impact on the current pipeline used to include icons in a Blender build, but lays the foundation to explore other workflows to do that, and tidies up the file.

Before submitting the patch I compared the png export with the version prior to the changes. I could find no difference, but I welcome an additional check.

Diff Detail

Repository

rB Blender

Branch

the_file (branched from master)

Build Status

Buildable 22874
Build 22874: arc lint + arc unit

Event Timeline

Francesco Siddi (fsiddi) requested review of this revision.Jun 21 2022, 2:07 PM

Francesco Siddi (fsiddi) created this revision.

Francesco Siddi (fsiddi) edited the summary of this revision. (Show Details)

Thanks for the (monkey) work! It was a real mess.

Once approved, a note about adding new icon groups should be added to the documentation at https://wiki.blender.org/wiki/Source/Interface/Icons

Comparison on how bad it used to be, to this patch:

+1 from me. @Dalai Felinto (dfelinto) may also want to chime in since he's been involved with icons recently.

Pablo Vazquez (pablovazquez) added a reviewer: Dalai Felinto (dfelinto).Jun 21 2022, 3:09 PM

If you can still build icons with this, it is a no-brainer, +1 for me.
(that said, I can no longer build icons here for whatever reason, and would rather not have to investigate why. So if anyone can confirm that you can still create the icons with this change, +1 for me)

A very nice improvement indeed. There are some other pending patches touching the icon file. So I want to check on possible conflicts and the best order to merge things first.

If you point me to the pending patches I'm available to update them once this is merged.

This is probably the main one: https://developer.blender.org/D13068

Just leaving a mention about rB011327 that introduces a new icon for snapping. To remember to keep this patch up-to-date, or merge as soon as possible to avoid further conflicts.