Page MenuHome

Fix T98925: Editor panels are broken
ClosedPublic

Authored by Richard Antalik (ISS) on Jun 21 2022, 3:46 PM.

Details

Summary

Commit 277fa2f441f4 added channels region to unintended editors if sequencer was
used in area. This caused issues with some editors having 2 tool regions and
non functioning side panel.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jun 21 2022, 3:46 PM
Richard Antalik (ISS) created this revision.
Richard Antalik (ISS) planned changes to this revision.Jun 21 2022, 4:16 PM

I have used BKE_area_find_region_type in different context, which is also not correct, so will fix that as well. A code to clean up potentially broken .blend files is also needed, so will add that as well.

  • Always use correct regionbase when lookiong for regions within specific editor, fix broken files.
  • Remove unnecessary whitespace changes
Campbell Barton (campbellbarton) added inline comments.
source/blender/blenloader/intern/versioning_300.c
598–606

Since this is generally useful, I'd rather this be moved into a BKE utility function. e.g. BKE_region_find_in_listbase_by_type(...) the functions doc-string can note that this is useful for versioning where either the Area or SpaceLink's regionbase are typical inputs.

This revision is now accepted and ready to land.Jun 24 2022, 1:19 AM
  • Add function to find region to BKE code.
This revision was automatically updated to reflect the committed changes.