Details
Diff Detail
- Repository
- rB Blender
- Branch
- arcpatch-D15257 (branched from master)
- Build Status
Buildable 22632 Build 22632: arc lint + arc unit
Event Timeline
| intern/cycles/device/metal/device_impl.mm | ||
|---|---|---|
| 284–289 | Having timing information is fine, but such changes should be sneaked into a change which advertises self as a change in device naming. | |
| 630 | How is this related to the device naming changes? | |
| intern/cycles/util/system.cpp | ||
| 77 ↗ | (On Diff #52735) | This change technically breaks scripts compatibility with an immediate outcome that it will have a direct affect on the opendata.blender.org. For example the current CPU name 'Intel(R) Xeon(R) W-3245 CPU @ 3.20GHz is changed to 'Intel(R) Xeon(R) W-3245 CPU @ 3.20GHz (CPU). Changes in the CPU naming is also not covered in the description of the change. So I can not give any suggestions about possible non-breaking changes solution here as I am not sure what was the problem this change aimed to fix. |
| intern/cycles/device/metal/device_impl.mm | ||
|---|---|---|
| 284–289 | Split out into D15268 | |
| 630 | Split out into D15267 | |
| intern/cycles/util/system.cpp | ||
| 77 ↗ | (On Diff #52735) | I have reverted this change. The intention was to clarify the device names in the device preferences panel. Without this the device names will be, e.g:
I still think it would be nicer to add the clarification for the CPU, but we might need to do this closer to the UI code so as not to break anything that relies on string matching. |
Thanks for splitting the change to a separate patches!
Think patch seems good to go as it is now.
For the M1 CPU: we can indeed alter the label in the interface, avoiding changes on the API side. Not sure whether showing the exact CPU name is the best way there even: what matters is that you enable CPU support so that work is split on all the compute devices. Exact frequency and brand does not add that much information there IMO, that's what belongs to the system-info.