Test/Eevee: Increase failure threshold for image tests.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 22 2022, 8:28 AM.

Details

Reviewers

Clément Foucault (fclem)
Brecht Van Lommel (brecht)

Commits

rBf748a81f259c: Test/Eevee: Increase failure threshold for image tests.

Summary

Makes the current test cases pass on NVIDIA 1080Ti/515.
The tests still fail on other platforms (AMD, Intel). Some are actual failures.
Other require platform specific reference images.

Original patch provided by Brecht van Lommel.

Diff Detail

Repository

rB Blender

Branch

temp-T99046-render-test-increase-fail-threshold

Build Status

Buildable 22625
Build 22625: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 22 2022, 8:28 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B22625: Diff 52758.Jun 22 2022, 8:28 AM

Jeroen Bakker (jbakker) retitled this revision from Increase render threshold for image test. to Test/Eevee: Increase failure threshold for image test..Jun 22 2022, 8:30 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added reviewers: Clément Foucault (fclem), Brecht Van Lommel (brecht).

Jeroen Bakker (jbakker) added projects: EEVEE & Viewport, Restricted Project.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) retitled this revision from Test/Eevee: Increase failure threshold for image test. to Test/Eevee: Increase failure threshold for image tests..

A similar fix can be done for MacOS workbench hair as a threshold of 0.05 would pass the test.
Adding support for other platforms would IMO require platform specific images.

Brecht Van Lommel (brecht) accepted this revision.Jun 22 2022, 4:27 PM

This revision is now accepted and ready to land.Jun 22 2022, 4:27 PM

Closed by commit rBf748a81f259c: Test/Eevee: Increase failure threshold for image tests. (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 24 2022, 1:45 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBf748a81f259c: Test/Eevee: Increase failure threshold for image tests..