Details

Reviewers

Brecht Van Lommel (brecht)
Clément Foucault (fclem)

Maniphest Tasks

T99046: Regression tests: Platform specific reference images

Commits

rB3393b7137e24: RenderReport: Add option to add platform specific overrides.

Summary

Reference images in the reference_override_dir will be chosen before
images in reference_dir. This allows platform specific reference
images, with a common base.

Ignored when set to None. The caller is responsible
of setting the reference override dir as the unit test is more aware
what the definition of a platform is.

Patch adds gpu.platform.device_type_get function to get the device
type that blender has detected.

Diff Detail

Repository

rB Blender

Branch

temp-T99046-platform-reference-images (branched from master)

Build Status

Buildable 22626
Build 22626: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Jun 22 2022, 9:56 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B22626: Diff 52759.Jun 22 2022, 9:56 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 22 2022, 9:57 AM

Jeroen Bakker (jbakker) added reviewers: Brecht Van Lommel (brecht), Clément Foucault (fclem).

Jeroen Bakker (jbakker) added projects: EEVEE & Viewport, Restricted Project.

Renamed to reference override dir

Harbormaster completed remote builds in B22627: Diff 52760.Jun 22 2022, 9:58 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 22 2022, 9:59 AM

Jeroen Bakker (jbakker) added a task: T99046: Regression tests: Platform specific reference images .Jun 22 2022, 10:03 AM

Get GPU platform.
Added GPU info as script to solve initialization errors.

Harbormaster completed remote builds in B22637: Diff 52784.Jun 22 2022, 2:05 PM

Brecht Van Lommel (brecht) requested changes to this revision.Jun 22 2022, 4:37 PM

Brecht Van Lommel (brecht) added inline comments.

tests/python/gpu_info.py
1 ↗	(On Diff #52784)	It's not clear to me how the GPU backend gets initialized to be able to access the vendor.
4–6 ↗	(On Diff #52784)	Code style: `+` -> `+` .
tests/python/modules/render_report.py
88–92	Rename `platform` to `override` for consistency.
90	Should be `os.path.exists(platform_img)`?

This revision now requires changes to proceed.Jun 22 2022, 4:37 PM

Added Python API for devce type.
Documented usage of gpu_info.
Removed references to platform.

Harbormaster completed remote builds in B22641: Diff 52795.Jun 22 2022, 5:13 PM

Jeroen Bakker (jbakker) added inline comments.Jun 22 2022, 5:14 PM

tests/python/gpu_info.py
1 ↗	(On Diff #52784)	The GPU backend is initialized when windows manager is initialized (hence I had to remove the --background parameter). Also the --python-expr didn't work as expected. Background rendering is working as draw manager detects and creates its own context. I found it to harmful to do a similar trick. Will write a usage comment at the start of this script.
4 ↗	(On Diff #52784)	The vendor string is platform dependent. It would be better to use `eGPUDeviceType`, `eGPUOSType` and `eGPUDriverType` to reuse code.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 22 2022, 5:15 PM

Jeroen Bakker (jbakker) planned changes to this revision.Jul 22 2022, 10:08 PM

Jeroen Bakker (jbakker) marked an inline comment as not done.

I missed that this patch got updated. I didn't spot issues in the current implementation, though not sure what kind of changes you have planned.

Popping up a window while running the tests is not ideal, not sure how much that would get in the way in practice. Possibly you could do a tiny workbench render to initialize the GPU in background mode.

Found a bug where I missed a rename.