Differential D15268

Cycles: Add diagnostic tracing of MTLLibrary compilation time
ClosedPublic
Actions

Authored by Michael Jones (michael_jones) on Jun 22 2022, 11:38 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBd8e9647ae26b: Cycles: Add diagnostic tracing of MTLLibrary compilation time

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 22630
Build 22630: arc lint + arc unit

Event Timeline

Michael Jones (michael_jones) requested review of this revision.Jun 22 2022, 11:38 AM

Michael Jones (michael_jones) created this revision.

Harbormaster completed remote builds in B22630: Diff 52765.Jun 22 2022, 11:38 AM

Michael Jones (michael_jones) mentioned this in D15257: Cycles: Distinguish Apple GPUs by core count.Jun 22 2022, 11:52 AM

Minor suggestion: more const the better! Otherwise seems good :)

intern/cycles/device/metal/device_impl.mm
284

Use const

Harbormaster completed remote builds in B22646: Diff 52807.Jun 22 2022, 11:44 PM

Michael Jones (michael_jones) marked an inline comment as done.Jun 22 2022, 11:45 PM

Sergey Sharybin (sergey) accepted this revision.Jun 23 2022, 10:46 AM

This revision is now accepted and ready to land.Jun 23 2022, 10:46 AM

Closed by commit rBd8e9647ae26b: Cycles: Add diagnostic tracing of MTLLibrary compilation time (authored by Michael Jones <michael_jones>, committed by Michael Jones (michael_jones)). · Explain WhyJun 23 2022, 11:06 AM

This revision was automatically updated to reflect the committed changes.

Michael Jones (michael_jones) added a commit: rBd8e9647ae26b: Cycles: Add diagnostic tracing of MTLLibrary compilation time.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

device/

metal/

device_impl.mm

8 lines

Diff 52765

View Options

intern/cycles/device/metal/device_impl.mm

Cycles: Add diagnostic tracing of MTLLibrary compilation timeClosedPublicActions