Fix T98427: Crash adding quick effects smoke from Python
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jun 22 2022, 1:26 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)
Sonny Campbell (SonnyCampbell_Unity)

Maniphest Tasks

T98427: Adding quick effects smoke with python raises segmentation fault

Summary

Manta flow used the __main__ namespace which it was executed in,
this caused a bug when calculating fluid from Python, which clears
it's __main__ name-space after execution.
This caused Manta-flows name space to be cleared too.

Resolve this by creating a separate name-space for manta-flow.

Diff Detail

Repository

rB Blender

Branch

TEMP-T98427-FIX (branched from master)

Build Status

Buildable 22678
Build 22678: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Jun 22 2022, 1:26 PM

Campbell Barton (campbellbarton) created this revision.

Harbormaster completed remote builds in B22634: Diff 52780.Jun 22 2022, 1:26 PM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Jun 22 2022, 1:27 PM

Campbell Barton (campbellbarton) added a task: T98427: Adding quick effects smoke with python raises segmentation fault.

Campbell Barton (campbellbarton) mentioned this in D15223: Fix T98427: Adding quick effects smoke with python raises segmentation fault.Jun 22 2022, 1:38 PM

terminateMantaflow() isn't actually called anywhere

intern/mantaflow/intern/MANTA_main.cpp
645–646	Probably don't need a null check here and also in `manta_python_main_module_ensure`
706	From checking the source code I couldn't actually find `terminateMantaflow()` being called anywhere, I put the clearing functionality in the destructor but should probably call `terminateMantaflow()` there

This revision now requires changes to proceed.Jun 24 2022, 1:58 PM

Update based on feedback.

Harbormaster completed remote builds in B22678: Diff 52869.Jun 24 2022, 2:39 PM

Regarding terminateMantaflow not being called, I think the fix would be to call this function as freeing the module elsewhere doesn't make so much sense.
Although I think calling this is outside the scope of this patch.

In practice this would only run on exit so it's more of a technicality when the module is kept while Blender runs.

Sonny Campbell (SonnyCampbell_Unity) accepted this revision.Jun 24 2022, 3:08 PM

This revision is now accepted and ready to land.Jun 24 2022, 3:08 PM

Campbell Barton (campbellbarton) mentioned this in rBad8add5f0cbe: Fix T98427: Crash adding quick effects smoke from Python.Jun 24 2022, 3:30 PM

Thanks, committed rBad8add5f0cbe1b5abb85a6cf510e52b66de273e9, closing.

Sonny Campbell (SonnyCampbell_Unity) mentioned this in T89860: Mantaflow crashes if the scene has auto running script which disables an addon..Jun 24 2022, 4:10 PM

Sonny Campbell (SonnyCampbell_Unity) mentioned this in T87828: Mantaflow error when using blender in background mode.Jun 24 2022, 4:14 PM