Page MenuHome
Differential D15285

Fix T99130: Spline factor gets messed up if one hair is too short
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Jun 24 2022, 12:44 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Maniphest Tasks
T99130: Experimental Hair: Spline factor gets messed up if one hair is too short
Commits
rBf1d191120f4f: Fix T99130: Spline factor gets messed up if one hair is too short
Summary

In the cases where length is zero, we simply equally distribute the value based on the control point/curve index.

Test file:

spline_curves.blend96 KBDownload

Diff Detail

Repository
rB Blender
Branch
fix-spline-parameter (branched from master)
Build Status
Buildable 22672
Build 22672: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) requested review of this revision.Jun 24 2022, 12:44 PM
Dalai Felinto (dfelinto) created this revision.
Harbormaster completed remote builds in B22672: Diff 52862.Jun 24 2022, 12:44 PM
Dalai Felinto (dfelinto) updated this revision to Diff 52863.Jun 24 2022, 12:57 PM

Support curves as well

Harbormaster completed remote builds in B22673: Diff 52863.Jun 24 2022, 12:57 PM
Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Jun 24 2022, 12:58 PM
Dalai Felinto (dfelinto) added a reviewer: Jacques Lucke (JacquesLucke).
Dalai Felinto (dfelinto) added a project: Geometry Nodes.
Hans Goudey (HooglyBoogly) added a task: T99130: Experimental Hair: Spline factor gets messed up if one hair is too short.Jun 24 2022, 2:37 PM
Dalai Felinto (dfelinto) planned changes to this revision.Jun 24 2022, 2:44 PM

I will add comments to the code.

Dalai Felinto (dfelinto) updated this revision to Diff 52871.Jun 24 2022, 3:25 PM

Add comments in the code.

Harbormaster completed remote builds in B22680: Diff 52871.Jun 24 2022, 3:25 PM
Hans Goudey (HooglyBoogly) accepted this revision.Jun 24 2022, 3:32 PM

Thanks for the comments. It would be nice to add a little note about this to the manual, since there's no other way to verify the behavior if you encounter it.

source/blender/nodes/geometry/nodes/node_geo_curve_spline_parameter.cc
133–136

I think this is a bit simpler (and makes it conceptually parallel)

This revision is now accepted and ready to land.Jun 24 2022, 3:32 PM
Dalai Felinto (dfelinto) marked an inline comment as done.Jun 24 2022, 3:36 PM

Thanks, I incorporated your changes and will update the manual now after committing this.

Closed by commit rBf1d191120f4f: Fix T99130: Spline factor gets messed up if one hair is too short (authored by Dalai Felinto (dfelinto)). · Explain WhyJun 24 2022, 3:37 PM
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a commit: rBf1d191120f4f: Fix T99130: Spline factor gets messed up if one hair is too short.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
14 lines

Diff 52862

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_spline_parameter.cc

Loading...