Page MenuHome

Fix GPU Subdiv Crash
ClosedPublic

Authored by Joseph Eagar (joeedh) on Jun 27 2022, 1:51 AM.

Diff Detail

Event Timeline

Kévin Dietrich (kevindietrich) requested changes to this revision.Jun 27 2022, 11:29 AM

Overall this looks good, I have some minor comments.

source/blender/draw/intern/draw_cache_impl_subdivision.cc
1473–1475

This should check draw_subdiv_cache_need_polygon_data like the other routines.

if (!draw_subdiv_cache_need_polygon_data(cache)) {
  /* Happens on meshes with only loose geometry. */
  return;
}
source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc
197

Can be const BMEdge *bm_edge.

203

Can be marked const as well.

This revision now requires changes to proceed.Jun 27 2022, 11:29 AM
Joseph Eagar (joeedh) marked 2 inline comments as done.
This revision is now accepted and ready to land.Jun 29 2022, 10:00 AM