Jeroen Bakker (jbakker) retitled this revision from Draw: Curve outline drawing in object mode. to Draw: Curve outline drawing in object mode. [WIP].Jun 28 2022, 10:56 AM

Jeroen Bakker (jbakker) added projects: EEVEE & Viewport, Geometry Nodes.

Jeroen Bakker (jbakker) added a task: T95933: Support selecting new curves object..

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 28 2022, 10:59 AM

Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).Jun 28 2022, 11:08 AM

Draw: Add GPU selection for new curve objects.

Harbormaster completed remote builds in B22725: Diff 52988.Jun 28 2022, 12:03 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 28 2022, 12:03 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 28 2022, 12:10 PM

Add support for clipping planes

Harbormaster completed remote builds in B22726: Diff 52989.Jun 28 2022, 12:11 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jun 28 2022, 12:13 PM

Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Jun 28 2022, 2:49 PM

Testing.
Try to push radius.
Set a minimum radius for curve rendering. (WIP)

The minimum radius is still WIP as it uses a different approach than initially planned.
It is cheaper, but might need some trickery to get radius 0 working.

Harbormaster completed remote builds in B22738: Diff 53004.Jun 28 2022, 4:05 PM

The active selection should not be visible when in curve sculpt mode.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jul 1 2022, 8:47 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jul 1 2022, 8:59 AM

Fix pushing thickness when curve doens't have a thickness.
Don't show outlines in sculpt curve mode.

Harbormaster completed remote builds in B22813: Diff 53144.Jul 1 2022, 9:00 AM

Merge branch 'master' into temp-T95933-object-mode-curve-selection
Removed hack where thick_time was in world space (shading artifacts).

Harbormaster completed remote builds in B22816: Diff 53154.Jul 1 2022, 12:15 PM

Viewport size aware.

Harbormaster completed remote builds in B22817: Diff 53155.Jul 1 2022, 1:19 PM

Jeroen Bakker (jbakker) retitled this revision from Draw: Curve outline drawing in object mode. [WIP] to Draw: Curve outline drawing in object mode..Jul 1 2022, 1:23 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added reviewers: Dalai Felinto (dfelinto), Hans Goudey (HooglyBoogly), Clément Foucault (fclem).

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added a subscriber: Clément Foucault (fclem).

Always offset the outline with a single pixel.

Harbormaster completed remote builds in B22818: Diff 53156.Jul 1 2022, 1:26 PM

Jeroen Bakker (jbakker) added inline comments.Jul 1 2022, 1:39 PM

source/blender/draw/engines/overlay/shaders/overlay_outline_prepass_curves_vert.glsl
60	`*0.5`
70	Is this still in use?

Hans Goudey (HooglyBoogly) added inline comments.Jul 1 2022, 10:31 PM

source/blender/draw/engines/overlay/overlay_extra.c
1530–1531 ↗	(On Diff #53156)	I think it would be better to use versioning to disable the `OB_DRAWBOUNDOX` flag from curves objects, and remove it in the three cases with the `/* TODO: Remove once there is actual drawing. */` comment.

Jeroen Bakker (jbakker) added inline comments.Jul 4 2022, 4:05 PM

source/blender/draw/engines/overlay/overlay_extra.c
1530–1531 ↗	(On Diff #53156)	Not sure, the has_bounds and draw_bounds work together. has bounds are for object types that never should be drawn with boxes. I see I have made a mistake. OB_CURVES should not be part of this list. as it should be drawn the way how the user has set it up. I will revert this change.

Duarte Farrajota Ramos (duarteframos) awarded a token.Jul 4 2022, 6:15 PM

Clément Foucault (fclem) added inline comments.Jul 5 2022, 3:02 PM

source/blender/draw/engines/overlay/shaders/overlay_outline_prepass_curves_vert.glsl
33	Use `drw_view.winmat` instead. This was recently refactored / mass renamed.
52–62	This whole part could be better commented. I am not sure what `d` is (I guess the screen space normal vector to the curve). I think you can have the same result by just copying what `hair_get_pos_tan_binor_time` does and just scale and/or clamp the `thick_time`. You can know the world space radius to clamp to by using (untested) `point_world_to_ndc(center_world_pos).w * minimum_radius_in_pixel * drw_view.viewport_size_inverse.y * drw_view.wininv[1][1]` or something like that.
source/blender/draw/intern/shaders/common_hair_lib.glsl
220–232	I would rename the function `hair_get_pos_tan_binor_time_no_expand` and move this block to `hair_get_pos_tan_binor_time`. This would remove the need to rename `wpos` to `orig_wpos`.