Paths

Table of Contentst

Differential D15311

Cleanup: Remove scene frame macros (`CFRA` et al.)
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Jun 28 2022, 3:14 PM.

Tags

Subscribers

Sergey Sharybin (sergey)

Tokens

"Love" token, awarded by sergey."Love" token, awarded by HooglyBoogly."Manufacturing Defect?" token, awarded by JacquesLucke.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rB65166e145b4d: Cleanup: Remove scene frame macros (`CFRA` et al.)

Summary

Removes the following macros for scene/render frame values:

CFRA
SUBFRA
SFRA
EFRA

These macros don't add much, other than saving a few characters when typing. It's not immediately clear what they refer to, they just hide what they actually access. Just be explicit and clear about that.
Plus these macros gave read and write access to the variables, so eyesores like this would be done:

CFRA = some_frame_nbr;

Diff Detail

Repository

Branch

master

Build Status

Buildable 22737
Build 22737: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Jun 28 2022, 3:14 PM

Julian Eisel (Severin) created this revision.

Harbormaster completed remote builds in B22737: Diff 53001.Jun 28 2022, 3:15 PM

Julian Eisel (Severin) added a project: Core.Jun 28 2022, 3:16 PM

Julian Eisel (Severin) edited the summary of this revision. (Show Details)Jun 28 2022, 3:18 PM

Jacques Lucke (JacquesLucke) awarded a token.Jun 28 2022, 4:55 PM

Hans Goudey (HooglyBoogly) awarded a token.Jun 28 2022, 5:36 PM

Sergey Sharybin (sergey) awarded a token.Jun 29 2022, 10:27 AM

From a quick reading didn't spot obvious mistakes.

This revision is now accepted and ready to land.Jun 30 2022, 4:57 PM

Closed by commit rB65166e145b4d: Cleanup: Remove scene frame macros (`CFRA` et al.) (authored by Julian Eisel (Severin)). · Explain WhyJun 30 2022, 6:44 PM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rB65166e145b4d: Cleanup: Remove scene frame macros (`CFRA` et al.).

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

gpencil_curve.c

2 lines

gpencil_geom.cc

4 lines

2 lines

24 lines

18 lines

draw/

engines/

eevee/

6 lines

overlay/

overlay_extra.c

7 lines

editors/

animation/

anim_channels_defines.c

12 lines

24 lines

12 lines

anim_motion_paths.c

8 lines

14 lines

keyframes_edit.c

4 lines

keyframes_general.c

8 lines

19 lines

armature/

4 lines

2 lines

4 lines

pose_transform.c

6 lines

gpencil/

annotate_draw.c

8 lines

annotate_paint.c

2 lines

editaction_gpencil.c

14 lines

gpencil_add_blank.c

2 lines

gpencil_add_monkey.c

4 lines

gpencil_add_stroke.c

4 lines

gpencil_bake_animation.cc

8 lines

gpencil_convert.c

8 lines

6 lines

12 lines

6 lines

gpencil_interpolate.c

8 lines

gpencil_merge.c

2 lines

gpencil_mesh.cc

4 lines

gpencil_paint.c

4 lines

gpencil_primitive.c

4 lines

gpencil_sculpt_paint.c

4 lines

gpencil_select.c

2 lines

io/

8 lines

io_gpencil_export.c

12 lines

io_gpencil_import.c

6 lines

8 lines

mask/

6 lines

2 lines

mask_editaction.c

2 lines

8 lines

mask_shapekey.c

8 lines

object/

2 lines

physics/

particle_edit.c

6 lines

physics_fluid.c

8 lines

render/

render_opengl.cc

15 lines

render_preview.cc

2 lines

screen/

28 lines

space_action/

10 lines

action_select.c

12 lines

8 lines

space_clip/

10 lines

6 lines

clip_graph_ops.c

8 lines

10 lines

12 lines

9 lines

tracking_ops_track.c

4 lines

space_graph/

18 lines

8 lines

8 lines

space_image/

image_buttons.c

2 lines

3 lines

8 lines

space_nla/

6 lines

6 lines

4 lines

space_node/

2 lines

space_sequencer/

sequencer_add.c

4 lines

sequencer_edit.c

14 lines

sequencer_select.c

10 lines

space_view3d/

2 lines

view3d_gizmo_ruler.c

4 lines

2 lines

transform/

transform_convert_action.c

12 lines

transform_convert_armature.c

4 lines

transform_convert_gpencil.c

2 lines

transform_convert_graph.c

14 lines

transform_convert_mask.c

4 lines

transform_convert_nla.c

14 lines

transform_convert_object.c

4 lines

transform_convert_sequencer.c

4 lines

transform_convert_sequencer_image.c

10 lines

transform_mode_timescale.c

4 lines

transform_snap_object.cc

2 lines

transform_snap_sequencer.c

2 lines

util/

ed_util_imbuf.c

2 lines

gpencil_modifiers/

intern/

MOD_gpencil_util.c

4 lines

MOD_gpencillattice.c

4 lines

MOD_gpencilmirror.c

4 lines

MOD_gpencilshrinkwrap.c

4 lines

io/

gpencil/

intern/

gpencil_io_capi.cc

4 lines

wavefront_obj/

exporter/

obj_exporter.cc

6 lines

makesdna/

DNA_scene_types.h

4 lines

sequencer/

intern/

strip_relations.c

2 lines

windowmanager/

gizmo/

intern/

wm_gizmo_target_props.c

2 lines

Diff 53001

source/blender/blenkernel/intern/gpencil_curve.c

Loading...

source/blender/blenkernel/intern/gpencil_geom.cc

Loading...

source/blender/blenkernel/intern/image.cc

Loading...

source/blender/blenkernel/intern/pointcache.c

Loading...

source/blender/blenkernel/intern/sound.c

Loading...

source/blender/draw/engines/eevee/eevee_engine.c

Loading...

source/blender/draw/engines/overlay/overlay_extra.c

Loading...

source/blender/editors/animation/anim_channels_defines.c

Loading...

source/blender/editors/animation/anim_draw.c

Loading...

source/blender/editors/animation/anim_markers.c

Loading...

source/blender/editors/animation/anim_motion_paths.c

Loading...

source/blender/editors/animation/anim_ops.c

Loading...

source/blender/editors/animation/keyframes_edit.c

Loading...

source/blender/editors/animation/keyframes_general.c

Loading...

source/blender/editors/animation/keyframing.c

Loading...

source/blender/editors/armature/pose_lib.c

Loading...

source/blender/editors/armature/pose_lib_2.c

Loading...

source/blender/editors/armature/pose_slide.c

Loading...

source/blender/editors/armature/pose_transform.c

Loading...

source/blender/editors/gpencil/annotate_draw.c

Loading...

source/blender/editors/gpencil/annotate_paint.c

Loading...

source/blender/editors/gpencil/editaction_gpencil.c

Loading...

source/blender/editors/gpencil/gpencil_add_blank.c

Loading...

source/blender/editors/gpencil/gpencil_add_monkey.c

Loading...

source/blender/editors/gpencil/gpencil_add_stroke.c

Loading...

source/blender/editors/gpencil/gpencil_bake_animation.cc

Loading...

source/blender/editors/gpencil/gpencil_convert.c

Loading...

source/blender/editors/gpencil/gpencil_data.c

Loading...

source/blender/editors/gpencil/gpencil_edit.c

Loading...

source/blender/editors/gpencil/gpencil_fill.c

Loading...

source/blender/editors/gpencil/gpencil_interpolate.c

Loading...

source/blender/editors/gpencil/gpencil_merge.c

Loading...

source/blender/editors/gpencil/gpencil_mesh.cc

Loading...

source/blender/editors/gpencil/gpencil_paint.c

Loading...

source/blender/editors/gpencil/gpencil_primitive.c

Loading...

source/blender/editors/gpencil/gpencil_sculpt_paint.c

Loading...

source/blender/editors/gpencil/gpencil_select.c

Loading...

source/blender/editors/io/io_alembic.c

Loading...

source/blender/editors/io/io_gpencil_export.c

Loading...

source/blender/editors/io/io_gpencil_import.c

Loading...

source/blender/editors/io/io_obj.c

Loading...

source/blender/editors/mask/mask_add.c

Loading...

source/blender/editors/mask/mask_draw.c

Loading...

source/blender/editors/mask/mask_editaction.c

Loading...

source/blender/editors/mask/mask_ops.c

Loading...

source/blender/editors/mask/mask_shapekey.c

Loading...

source/blender/editors/object/object_add.cc

Loading...

source/blender/editors/physics/particle_edit.c

Loading...

source/blender/editors/physics/physics_fluid.c

Loading...

source/blender/editors/render/render_opengl.cc

Loading...

source/blender/editors/render/render_preview.cc

Loading...

source/blender/editors/screen/screen_ops.c

Loading...

source/blender/editors/space_action/action_edit.c

Loading...

source/blender/editors/space_action/action_select.c

Loading...

source/blender/editors/space_action/space_action.c

Loading...

source/blender/editors/space_clip/clip_draw.c

Loading...

source/blender/editors/space_clip/clip_editor.c

Loading...

source/blender/editors/space_clip/clip_graph_ops.c

Loading...

source/blender/editors/space_clip/clip_ops.c

Loading...

source/blender/editors/space_clip/clip_utils.c

Loading...

source/blender/editors/space_clip/tracking_ops.c

Loading...

source/blender/editors/space_clip/tracking_ops_track.c

Loading...

source/blender/editors/space_graph/graph_edit.c

Loading...

source/blender/editors/space_graph/graph_ops.c

Loading...

source/blender/editors/space_graph/graph_select.c

Loading...

source/blender/editors/space_image/image_buttons.c

Loading...

source/blender/editors/space_image/image_draw.c

Loading...

source/blender/editors/space_image/image_ops.c

Loading...

source/blender/editors/space_nla/nla_edit.c

Loading...

source/blender/editors/space_nla/nla_select.c

Loading...

source/blender/editors/space_nla/space_nla.c

Loading...

source/blender/editors/space_node/drawnode.cc

Loading...

source/blender/editors/space_sequencer/sequencer_add.c

Loading...

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...

source/blender/editors/space_sequencer/sequencer_select.c

Loading...

source/blender/editors/space_view3d/view3d_draw.c

Loading...

source/blender/editors/space_view3d/view3d_gizmo_ruler.c

Loading...

source/blender/editors/space_view3d/view3d_utils.c

Loading...

source/blender/editors/transform/transform_convert_action.c

Loading...

source/blender/editors/transform/transform_convert_armature.c

Loading...

source/blender/editors/transform/transform_convert_gpencil.c

Loading...

source/blender/editors/transform/transform_convert_graph.c

Loading...

source/blender/editors/transform/transform_convert_mask.c

Loading...

source/blender/editors/transform/transform_convert_nla.c

Loading...

source/blender/editors/transform/transform_convert_object.c

Loading...

source/blender/editors/transform/transform_convert_sequencer.c

Loading...

source/blender/editors/transform/transform_convert_sequencer_image.c

Loading...

source/blender/editors/transform/transform_mode_timescale.c

Loading...

source/blender/editors/transform/transform_snap_object.cc

Loading...

source/blender/editors/transform/transform_snap_sequencer.c

Loading...

source/blender/editors/util/ed_util_imbuf.c

Loading...

source/blender/gpencil_modifiers/intern/MOD_gpencil_util.c

Loading...

source/blender/gpencil_modifiers/intern/MOD_gpencillattice.c

Loading...

source/blender/gpencil_modifiers/intern/MOD_gpencilmirror.c

Loading...

source/blender/gpencil_modifiers/intern/MOD_gpencilshrinkwrap.c

Loading...

source/blender/io/gpencil/intern/gpencil_io_capi.cc

Loading...

source/blender/io/wavefront_obj/exporter/obj_exporter.cc

Loading...

source/blender/makesdna/DNA_scene_types.h

Loading...

source/blender/sequencer/intern/strip_relations.c

Loading...

source/blender/windowmanager/gizmo/intern/wm_gizmo_target_props.c

Loading...