Paths

Table of Contentst

Differential D15318

Cycles: add more math functions for float4
ClosedPublic
Actions

Authored by Andrii Symkin (pembem22) on Jun 29 2022, 11:38 AM.

Details

Reviewers

Brecht Van Lommel (brecht)

Group Reviewers

Cycles

Commits

rBf00d9e80aec7: Cycles: add more math functions for float4

Summary

This patch adds more math functions for float4 to make them on par with float3 ones. It makes it possible to change the types of float3 variables to float4 without additional work.

Tested on CPU and CUDA.

Diff Detail

Repository

rB Blender

Branch

cycles-add-float4-functions

Build Status

Buildable 22768
Build 22768: arc lint + arc unit

Event Timeline

Andrii Symkin (pembem22) requested review of this revision.Jun 29 2022, 11:38 AM

Andrii Symkin (pembem22) created this revision.

Harbormaster completed remote builds in B22761: Diff 53050.Jun 29 2022, 11:38 AM

Andrii Symkin (pembem22) edited the summary of this revision. (Show Details)Jun 29 2022, 11:38 AM

Andrii Symkin (pembem22) added a reviewer: Cycles.

Andrii Symkin (pembem22) edited the summary of this revision. (Show Details)

Test build started:
https://builder.blender.org/admin/#/builders/18/builds/515

Fix compilation errors with NEON and SSE3

Harbormaster completed remote builds in B22768: Diff 53065.Jun 29 2022, 3:21 PM

New build:
https://builder.blender.org/admin/#/builders/18/builds/516

For the Metal errors, you can pass by value instead of by reference, makes no difference as this is inlined anyway.

And for extracing a float from _m128 , you can use _mm_cvtss_f32(a) instead of a.x.

This revision now requires changes to proceed.Jun 29 2022, 3:59 PM

makizar (makizar) awarded a token.Jun 29 2022, 7:52 PM

Fix compilation errors with Metal and SSE

Harbormaster completed remote builds in B22779: Diff 53085.Jun 29 2022, 8:45 PM

Brecht Van Lommel (brecht) accepted this revision.Jun 30 2022, 4:22 PM

This revision is now accepted and ready to land.Jun 30 2022, 4:22 PM

Closed by commit rBf00d9e80aec7: Cycles: add more math functions for float4 (authored by Andrii Symkin (pembem22), committed by Brecht Van Lommel (brecht)). · Explain WhyJun 30 2022, 4:29 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBf00d9e80aec7: Cycles: add more math functions for float4.

Andrii Symkin (pembem22) mentioned this in D15525: Cycles: add math functions for float8.Jul 25 2022, 9:52 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

util/

math_float4.h

140 lines

Diff 53065

View Options

intern/cycles/util/math_float4.h

Cycles: add more math functions for float4ClosedPublicActions