Page MenuHome
Differential D15322

Spreadsheet: display byte colors as scene linear floats
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jun 29 2022, 4:35 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T99205: Geometry nodes: vertex color read by named attribute node is in sRGB
Commits
rB6b508eb012b9: Spreadsheet: display byte colors as scene linear floats
Summary

The compression as sRGB is mostly an implementation detail and showing the
integers does not make it clear what the actual values are that will be used
for computations in geometry nodes. This follows the general convention that
colors in Blender are displayed and edited in scene linear floats.

The raw sRGB bytes can still be viewed as a tooltip.

Ref T99205

Diff Detail

Repository
rB Blender
Branch
linear-byte-color (branched from master)
Build Status
Buildable 22772
Build 22772: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jun 29 2022, 4:35 PM
Brecht Van Lommel (brecht) created this revision.
Harbormaster completed remote builds in B22771: Diff 53069.Jun 29 2022, 4:35 PM
Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Jun 29 2022, 4:39 PM
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/editors/space_spreadsheet/spreadsheet_layout.cc
348

This should probably use TIP_?

Brecht Van Lommel (brecht) updated this revision to Diff 53070.Jun 29 2022, 4:54 PM

Use TIP_.

Harbormaster completed remote builds in B22772: Diff 53070.Jun 29 2022, 4:54 PM
Hans Goudey (HooglyBoogly) accepted this revision.Jun 29 2022, 5:02 PM

I think there's a chance we should generalize the tooltip handling in the future, but this feels fine for me at this point.

This revision is now accepted and ready to land.Jun 29 2022, 5:02 PM
Closed by commit rB6b508eb012b9: Spreadsheet: display byte colors as scene linear floats (authored by Brecht Van Lommel (brecht)). · Explain WhyJun 29 2022, 5:09 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB6b508eb012b9: Spreadsheet: display byte colors as scene linear floats.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_spreadsheet/
4 lines
32 lines
11 lines
19 lines
makesdna/
2 lines
makesrna/
intern/
6 lines

Diff 53070

View Options

source/blender/editors/space_spreadsheet/space_spreadsheet.cc

Loading...
View Options

source/blender/editors/space_spreadsheet/spreadsheet_layout.cc

Loading...
View Options

source/blender/editors/space_spreadsheet/spreadsheet_row_filter.cc

Loading...
View Options

source/blender/editors/space_spreadsheet/spreadsheet_row_filter_ui.cc

Loading...
View Options

source/blender/makesdna/DNA_space_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...