Differential D15362

UV: Box and lasso selection for partially intersecting edges
ClosedPublic
Actions

Authored by Siddhartha Jejurkar (sidd017) on Jul 4 2022, 7:57 PM.

Tags

Subscribers

None

Tokens

"Like" token, awarded by campbellbarton."Like" token, awarded by PratikPB2123.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T99443: Box selection in uv editor does not work as expected with edge mode

Commits

rB52b7f2b08907: UV: Box and lasso selection for partially intersecting edges

Summary

In UV edge mode, box and lasso selections allow edge selections only
when the entire edge is contained within the selection area. This
doesn't consider any edges that partially overlap with the selection
area.

This is now fixed by adding a second pass, similar to how these
operators work for edit-mesh selections. Now if both operators are
unable to find any edges contained within the selection area, then
they will perform a second pass which checks for edges that partially
intersect with the selection area.

Now edge selection in the UV editor matches edit-mesh edge-selection
when drawing wire-frame.

Resolves T99443.

Diff Detail

Repository

Branch

uv-box-lasso-edge-fix (branched from master)

Build Status

Buildable 22850
Build 22850: arc lint + arc unit

Event Timeline

Siddhartha Jejurkar (sidd017) requested review of this revision.Jul 4 2022, 7:57 PM

Siddhartha Jejurkar (sidd017) created this revision.

Harbormaster completed remote builds in B22850: Diff 53228.Jul 4 2022, 7:57 PM

Siddhartha Jejurkar (sidd017) added a reviewer: Campbell Barton (campbellbarton).Jul 4 2022, 8:01 PM

Siddhartha Jejurkar (sidd017) added a project: Restricted Project.

Not including circle select in this patch as it appears to work as expected/correctly.

Pratik Borhade (PratikPB2123) awarded a token.Jul 5 2022, 8:54 AM

Rebase on master

Harbormaster completed remote builds in B22949: Diff 53528.Jul 12 2022, 5:25 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Jul 12 2022, 11:38 AM

Minor updates, correct spelling in comments, use a/b for arg names instead of 1/2.

Harbormaster completed remote builds in B22952: Diff 53535.Jul 12 2022, 11:48 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Jul 12 2022, 11:50 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2022, 11:52 AM

Closed by commit rB52b7f2b08907: UV: Box and lasso selection for partially intersecting edges (authored by Siddhartha Jejurkar (sidd017), committed by Campbell Barton (campbellbarton)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Campbell Barton (campbellbarton) added a commit: rB52b7f2b08907: UV: Box and lasso selection for partially intersecting edges.

Campbell Barton (campbellbarton) awarded a token.Jul 12 2022, 11:54 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

include/

6 lines

interface/

31 lines

uvedit/

uvedit_select.c

69 lines

Diff 53228

source/blender/editors/include/UI_view2d.h

Loading...

source/blender/editors/interface/view2d.cc

Loading...

source/blender/editors/uvedit/uvedit_select.c

Loading...