Fix T99453: Regression: Crash on calling menu search
ClosedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Jul 5 2022, 11:37 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Nate Rupsis (nrupsis)

Maniphest Tasks

T99453: Regression: Crash on calling menu search

Commits

rB3063d90cfc05: Fix T99453: Regression: Crash on calling menu search

Summary

Fix T99453.
Crash due to null pointer access.
So wrap the function call in simple if check

Diff Detail

Repository: rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Jul 5 2022, 11:37 AM

Pratik Borhade (PratikPB2123) created this revision.

LGTM! I just added @Nate Rupsis (nrupsis) as reviewer as he's the author of the commit that caused the issue, and I think it's good to include him in the review process. Even if it's a simple fix that clearly works ;-)

This revision is now accepted and ready to land.Jul 7 2022, 12:24 PM

ok :)

Closed by commit rB3063d90cfc05: Fix T99453: Regression: Crash on calling menu search (authored by Pratik Borhade (PratikPB2123), committed by Sybren A. Stüvel (sybren)). · Explain WhyJul 7 2022, 3:25 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rB3063d90cfc05: Fix T99453: Regression: Crash on calling menu search.

Completely missed this... Thanks for cleaning up my mess @Pratik Borhade (PratikPB2123) !

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

object/

object_vgroup.c

6 lines

Diff 53356

View Options

source/blender/editors/object/object_vgroup.c

Fix T99453: Regression: Crash on calling menu searchClosedPublicActions