Page MenuHome
Differential D15380

Fix T99332: Regression: Resize video in image editor does not update correctly
ClosedPublic
Actions

Authored by Nicolas (john-g-h-doe) on Jul 6 2022, 3:35 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBfc06b4c03356: Fix T99332: resize video in image editor does not update correctly

Diff Detail

Repository
rB Blender

Event Timeline

Nicolas (john-g-h-doe) requested review of this revision.Jul 6 2022, 3:35 AM
Nicolas (john-g-h-doe) created this revision.
Nicolas (john-g-h-doe) created this object with edit policy "Administrators".
Nicolas (john-g-h-doe) added a reviewer: blender (blenderanime).
Nicolas (john-g-h-doe) mentioned this in T99332: Regression: Resize video in image editor does not update correctly.Jul 6 2022, 9:31 AM
Brecht Van Lommel (brecht) edited reviewers, added: Brecht Van Lommel (brecht); removed: blender (blenderanime).Jul 6 2022, 10:34 AM
Brecht Van Lommel (brecht) removed a subscriber: blender (blenderanime).
Brecht Van Lommel (brecht) added a comment.Jul 6 2022, 3:34 PM

Thanks for the patch. However I think we should unify the code a bit more instead of adding exceptions where we sometimes pass a NULL image user.

I think this can be made to work changing image_user_from_active_tile to initialize the image user with the result from image_user_from_context if available, and only if not use BKE_imageuser_default.

Brecht Van Lommel (brecht) requested changes to this revision.Jul 6 2022, 3:34 PM
This revision now requires changes to proceed.Jul 6 2022, 3:34 PM
Nicolas (john-g-h-doe) updated this revision to Diff 53318.EditedJul 6 2022, 11:55 PM

@Brecht Van Lommel (brecht) I tried to make something in that direction.

  • called image_from_context() inside image_user_from_active_tile()
  • refactored image_user_from_active_tile()

I also tested to call image_user_from_context() inside image_user_from_active_tile(),
but we then got the Image->Resize option grayed out in the menu.

Brecht Van Lommel (brecht) accepted this revision.Jul 7 2022, 9:02 PM

I'm not sure why resize would be grayed out in the menu with that, but I got it working that way. Probably some problem in the implementation?

Thanks for the help, I'll commit my revised version of this patch.

This revision is now accepted and ready to land.Jul 7 2022, 9:02 PM
Closed by commit rBfc06b4c03356: Fix T99332: resize video in image editor does not update correctly (authored by Brecht Van Lommel (brecht)). · Explain WhyJul 7 2022, 9:02 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBfc06b4c03356: Fix T99332: resize video in image editor does not update correctly.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_image/
37 lines

Diff 53385

View Options

source/blender/editors/space_image/image_ops.c

Loading...