Paths

Table of Contentst

Differential D15386

Fix T99491: Crash when opening modifiers panel
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Jul 6 2022, 5:10 PM.

Tags

None

Subscribers

None

Details

Reviewers

Sybren A. Stüvel (sybren)
Amelie Fondevilla (afonde)

Maniphest Tasks

T99491: GPencil: Crash in graph editor after opening the f-curves modifier panel

Commits

rB051a341cf00c: Fix T99491: Crash when opening modifiers panel

Summary

This crashed because in get_active_fcurve_channel, the filter did not
filter out channels with no fcurve.

The fix adds the filter ANIMFILTER_FCURVESONLY.

See rB92d7f9ac56e0ff1e65c364487542dfb7c32a0a67 for the new filter.

Diff Detail

Repository: rB Blender

Event Timeline

Falk David (filedescriptor) requested review of this revision.Jul 6 2022, 5:10 PM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B22873: Diff 53295.Jul 6 2022, 5:10 PM

Antonio Vazquez (antoniov) added reviewers: Sybren A. Stüvel (sybren), Amelie Fondevilla (afonde).Jul 6 2022, 8:21 PM

Amelie Fondevilla (afonde) accepted this revision.Jul 7 2022, 11:35 AM

This revision is now accepted and ready to land.Jul 7 2022, 11:35 AM

Sybren A. Stüvel (sybren) accepted this revision.Jul 7 2022, 11:39 AM

Closed by commit rB051a341cf00c: Fix T99491: Crash when opening modifiers panel (authored by Falk David (filedescriptor)). · Explain WhyJul 7 2022, 11:56 AM

This revision was automatically updated to reflect the committed changes.

Falk David (filedescriptor) added a commit: rB051a341cf00c: Fix T99491: Crash when opening modifiers panel.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_graph/

2 lines

Diff 53343

source/blender/editors/space_graph/graph_utils.c

Loading...