Page MenuHome
Differential D15390

[T99382:UBSan] Fixed Indexing into null pointer UBSan warning
ClosedPublic
Actions

Authored by Loren Osborn (linux_dr) on Jul 7 2022, 8:56 AM.

Details

Reviewers
Clément Foucault (fclem)
Commits
rBdb46251209de: Fix ubsan warnings about indexing into null pointers
Summary

Under parent task T99382 (priority: Low)

UBSan warns when indexing into a null pointer. This should produce the same pointer value without triggering the UBSan warning.

Diff Detail

Repository
rB Blender

Event Timeline

Loren Osborn (linux_dr) requested review of this revision.Jul 7 2022, 8:56 AM
Loren Osborn (linux_dr) created this revision.
Loren Osborn (linux_dr) added a reviewer: Clément Foucault (fclem).Jul 7 2022, 7:50 PM

Hi Clément,

This looks like your code originally. Can you take a peek at it?

Thanks,

-Loren

Clément Foucault (fclem) accepted this revision.Jul 7 2022, 8:25 PM

Assembly result is identical or even better in clang case.

This revision is now accepted and ready to land.Jul 7 2022, 8:25 PM
Loren Osborn (linux_dr) mentioned this in T99382: [Parent Task] Fix UBSan issues.Jul 8 2022, 5:45 AM
Closed by commit rBdb46251209de: Fix ubsan warnings about indexing into null pointers (authored by Loren Osborn (linux_dr), committed by Brecht Van Lommel (brecht)). · Explain WhyAug 19 2022, 4:27 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBdb46251209de: Fix ubsan warnings about indexing into null pointers.

Revision Contents
Changeset List

PathSize
source/
blender/
gpu/
opengl/
6 lines

Diff 53335

View Options

source/blender/gpu/opengl/gl_index_buffer.hh

Loading...