Page MenuHome

Add a few UI strings to translation
ClosedPublic

Authored by Damien Picard (pioverfour) on Jul 7 2022, 3:27 PM.

Details

Summary

These are currently untranslatable.

@Bastien Montagne (mont29), is this the proper way to handle this? Or would you rather I create a task for these and we do them all at once between versions? Or re-use T43295? I can update the wiki depending on your answer.

Diff Detail

Repository
rB Blender

Event Timeline

Damien Picard (pioverfour) requested review of this revision.Jul 7 2022, 3:27 PM
Damien Picard (pioverfour) created this revision.
Bastien Montagne (mont29) requested changes to this revision.Jul 7 2022, 4:06 PM

Yes when submitting a patch, even if only for translations, creating a new Diff every time is the way to go.

T43295 is only to be used to report problems, without proposing a solution for them. Needless to say a patch is much more appreciated in that case!


This patch looks good in general, besides two points noted in comments below.

release/scripts/startup/bl_ui/space_userpref.py
1894

This is not something we want to do.
I know that in French you are supposed to add an unbreakable space in front of the colon, but we cannot start translating a single character, for many reasons (performances, way too generic translation, unexpected side effects, etc.).
So I think French UI translation will have to live with some non-spaced colons for the time being. ;)

2097

That one should not be needed? the string is already in the PO files at least.

This revision now requires changes to proceed.Jul 7 2022, 4:06 PM

Remove single “:” change.

Damien Picard (pioverfour) marked an inline comment as done.Jul 7 2022, 5:10 PM

Thanks. I was asking because I don’t want to take too much of your time in many small patches as I discover issues, and was wondering if it was better to batch them. Anyway, I’ll continue submitting patches when the need arises!

release/scripts/startup/bl_ui/space_userpref.py
1894

Ha ha okay, too bad for my compulsive typesetting ;)

2097

I thought so too, but probably because of the format string it’s not translated right now…

Thanks, LGTM, will commit on your behalf. :)

release/scripts/startup/bl_ui/space_userpref.py
2097

OOOohhh yes indeed, you are right!

This revision is now accepted and ready to land.Jul 8 2022, 11:36 AM