Paths

Table of Contentst

Differential D15396

Cleanup: Move mesh legacy conversion to a separate file
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jul 7 2022, 8:47 PM.

Tags

Subscribers

None

Tokens

"Like" token, awarded by campbellbarton.

Details

Reviewers

Campbell Barton (campbellbarton)

Commits

rBc4b32f1b291a: Cleanup: Move mesh legacy conversion to a separate file

Summary

It's helpful to make the separation of legacy data formats explicit,
because it clutters actively changed code less and makes it clear which
areas do not follow Blender's current design. In this case I separated
the MFace/"tessface" conversion code into a separate blenkernel
.cc file and header. This also makes refactoring to remove these
functions simpler because it's easier to find them.

In the future, conversions to the MLoopUV type and MVert
can be implemented here for the same reasons (see T95965).

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 7 2022, 8:47 PM

Hans Goudey (HooglyBoogly) created this revision.

One inline note of a change that seems unrelated, otherwise LGTM.

source/blender/makesdna/DNA_object_types.h
791–793	This looks unrelated to this patch.

This revision is now accepted and ready to land.Jul 8 2022, 2:28 AM

Campbell Barton (campbellbarton) awarded a token.Jul 8 2022, 2:28 AM

Hans Goudey (HooglyBoogly) added inline comments.Jul 8 2022, 3:45 AM

source/blender/makesdna/DNA_object_types.h
791–793	Thanks for catching that!

Closed by commit rBc4b32f1b291a: Cleanup: Move mesh legacy conversion to a separate file (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJul 8 2022, 5:43 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBc4b32f1b291a: Cleanup: Move mesh legacy conversion to a separate file.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

BKE_customdata.h

24 lines

61 lines

BKE_mesh_legacy_convert.h

73 lines

2 lines

intern/

122 lines

78 lines

mesh_evaluate.cc

272 lines

mesh_legacy_convert.cc

876 lines

mesh_tessellate.c

364 lines

1 line

particle_distribute.c

1 line

particle_system.c

1 line

blenloader/

intern/

versioning_280.c

1 line

draw/

intern/

draw_cache_impl_particles.c

1 line

editors/

curves/

intern/

1 line

physics/

particle_edit.c

1 line

particle_object.c

1 line

io/

alembic/

exporter/

abc_writer_hair.cc

1 line

collada/

collada_utils.cpp

1 line

makesdna/

DNA_object_types.h

4 lines

makesrna/

intern/

1 line

modifiers/

intern/

1 line

MOD_particlesystem.cc

1 line

Diff 53382

source/blender/blenkernel/BKE_customdata.h

Loading...

source/blender/blenkernel/BKE_mesh.h

Loading...

source/blender/blenkernel/BKE_mesh_legacy_convert.h

Loading...

source/blender/blenkernel/CMakeLists.txt

Loading...

source/blender/blenkernel/intern/customdata.cc

Loading...

source/blender/blenkernel/intern/mesh.cc

Loading...

source/blender/blenkernel/intern/mesh_evaluate.cc

Loading...

source/blender/blenkernel/intern/mesh_legacy_convert.cc

Loading...

source/blender/blenkernel/intern/mesh_tessellate.c

Loading...

source/blender/blenkernel/intern/particle.c

Loading...

source/blender/blenkernel/intern/particle_distribute.c

Loading...

source/blender/blenkernel/intern/particle_system.c

Loading...

source/blender/blenloader/intern/versioning_280.c

Loading...

source/blender/draw/intern/draw_cache_impl_particles.c

Loading...

source/blender/editors/curves/intern/curves_ops.cc

Loading...

source/blender/editors/physics/particle_edit.c

Loading...

source/blender/editors/physics/particle_object.c

Loading...

source/blender/io/alembic/exporter/abc_writer_hair.cc

Loading...

source/blender/io/collada/collada_utils.cpp

Loading...

source/blender/makesdna/DNA_object_types.h

Loading...

source/blender/makesrna/intern/rna_particle.c

Loading...

source/blender/modifiers/intern/MOD_explode.c

Loading...

source/blender/modifiers/intern/MOD_particlesystem.cc

Loading...