Page MenuHome
Differential D15401

Cleanup: Remove unused get_cage_mesh parameter.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jul 8 2022, 12:39 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB3ea91cecc939: Cleanup: remove unused get_cage_mesh parameter
Summary

We talked about it here already: D13824#368426.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jul 8 2022, 12:39 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B22902: Diff 53411.Jul 8 2022, 12:39 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jul 8 2022, 12:42 PM
Jacques Lucke (JacquesLucke) added a reviewer: Sergey Sharybin (sergey).
Sergey Sharybin (sergey) accepted this revision.Jul 19 2022, 5:05 PM

From the code side seems fine.

The description (which we consider a commit message) is much better to directly mention that the argument was always false, so that reader does not need to dig through the entire patch to see this, and does not need to go into discussion in another patch.

This revision is now accepted and ready to land.Jul 19 2022, 5:05 PM
Closed by commit rB3ea91cecc939: Cleanup: remove unused get_cage_mesh parameter (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJul 20 2022, 3:57 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB3ea91cecc939: Cleanup: remove unused get_cage_mesh parameter.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
6 lines
intern/
2 lines
4 lines
2 lines
13 lines
4 lines
editors/
space_spreadsheet/
2 lines
gpencil_modifiers/
intern/
2 lines
modifiers/
intern/
4 lines
10 lines
2 lines
2 lines
2 lines
2 lines
nodes/
geometry/
nodes/
3 lines

Diff 53873

View Options

source/blender/blenkernel/BKE_modifier.h

Loading...
View Options

source/blender/blenkernel/intern/data_transfer.c

Loading...
View Options

source/blender/blenkernel/intern/geometry_set_instances.cc

Loading...
View Options

source/blender/blenkernel/intern/gpencil_modifier.c

Loading...
View Options

source/blender/blenkernel/intern/modifier.c

Loading...
View Options

source/blender/blenkernel/intern/shrinkwrap.c

Loading...
View Options

source/blender/editors/space_spreadsheet/spreadsheet_data_source_geometry.cc

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilshrinkwrap.c

Loading...
View Options

source/blender/modifiers/intern/MOD_array.c

Loading...
View Options

source/blender/modifiers/intern/MOD_boolean.cc

Loading...
View Options

source/blender/modifiers/intern/MOD_mesh_to_volume.cc

Loading...
View Options

source/blender/modifiers/intern/MOD_meshdeform.c

Loading...
View Options

source/blender/modifiers/intern/MOD_surfacedeform.c

Loading...
View Options

source/blender/modifiers/intern/MOD_weightvgproximity.c

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_deform_curves_on_surface.cc

Loading...