Page MenuHome
Differential D15433

Fix potential crashing when displaying or rendering Grease Pencil object on older hardware
ClosedPublic
Actions

Authored by Khoi Dau (khoidauminh) on Jul 12 2022, 3:56 PM.

Details

Reviewers
Clément Foucault (fclem)
Germano Cavalcante (mano-wii)
Commits
rB93253d5dcc29: Fix T99103: crash when displaying or rendering Grease Pencil object
Summary

This is my first time submitting a patch.

The bug has been addressed in T99103.

On some hardware/systems, blender may crash when adding, rendering or displaying Grease Pencil objects.

In /source/blender/draw/engines/gpencil/shaders/gpencil_vert.glsl, line 35:

gpMaterialFlag gp_flag = floatBitsToInt(gp_mat._flag);

gpMaterialFlag is of type uint. This is a mismatched-type assignment that can cause crashes on some hardware/systems with GLSL that do not support implicit type casting.

The function can be wrapped in the unit constructor to explicitly convert the return type.

Update: using floatBitsToUint for type conversion.

Diff Detail

Repository
rB Blender

Event Timeline

Khoi Dau (khoidauminh) requested review of this revision.Jul 12 2022, 3:56 PM
Khoi Dau (khoidauminh) created this revision.
Antonio Vazquez (antoniov) added reviewers: Clément Foucault (fclem), Germano Cavalcante (mano-wii).Jul 12 2022, 3:57 PM
Germano Cavalcante (mano-wii) added a comment.Jul 12 2022, 4:03 PM

Could we use floatBitsToUint instead?

Khoi Dau (khoidauminh) added a comment.Jul 12 2022, 4:09 PM

Definitely floatBitsToUint. I tried using the function but made a typo in the name and thought it was unavailable.

Khoi Dau (khoidauminh) updated this revision to Diff 53549.Jul 12 2022, 4:14 PM
Khoi Dau (khoidauminh) edited the summary of this revision. (Show Details)
Germano Cavalcante (mano-wii) accepted this revision.Jul 12 2022, 4:34 PM
This revision is now accepted and ready to land.Jul 12 2022, 4:34 PM
Closed by commit rB93253d5dcc29: Fix T99103: crash when displaying or rendering Grease Pencil object (authored by Khoi Dau (khoidauminh), committed by Germano Cavalcante (mano-wii)). · Explain WhyJul 12 2022, 4:35 PM
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB93253d5dcc29: Fix T99103: crash when displaying or rendering Grease Pencil object.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
gpencil/
shaders/
2 lines

Diff 53551

View Options

source/blender/draw/engines/gpencil/shaders/gpencil_vert.glsl

Loading...