Page MenuHome
Differential D15436

Fix: Move DRW_shgroup_add_material_resources(grp, mat) to after the null-check for grp.
ClosedPublic
Actions

Authored by Martijn Versteegh (Baardaap) on Jul 12 2022, 4:44 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T99646: Regression: Crash when rendering Quick effect Liquid
Commits
rB7e814d155f25: Fix: Move DRW_shgroup_add_material_resources(grp, mat) to after the null-check…
rB8e1323f63309: Fix: Move DRW_shgroup_add_material_resources(grp, mat) to after the null-check…

Diff Detail

Repository
rB Blender

Event Timeline

Martijn Versteegh (Baardaap) requested review of this revision.Jul 12 2022, 4:44 PM
Martijn Versteegh (Baardaap) created this revision.
Harbormaster completed remote builds in B22957: Diff 53553.Jul 12 2022, 4:44 PM
Martijn Versteegh (Baardaap) added a reviewer: Clément Foucault (fclem).Jul 12 2022, 4:47 PM

Hi Clement.

I think this is just a fix for a small mistake?

Martijn Versteegh (Baardaap) added a task: T99646: Regression: Crash when rendering Quick effect Liquid.Jul 12 2022, 4:52 PM
Clément Foucault (fclem) accepted this revision.Jul 12 2022, 4:57 PM
This revision is now accepted and ready to land.Jul 12 2022, 4:57 PM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Jul 12 2022, 5:35 PM

@Clément Foucault (fclem) hi, please also commit the patch :)

Pratik Borhade (PratikPB2123) added a comment.Jul 12 2022, 5:50 PM

AFAICS that line was added in rBa5ac0375b0d5: Fix T98697: EEVEE: Regression: Missing custom property from volumetrics
and Same commit was also backported to 3.2.1
@Martijn Versteegh (Baardaap) , can you check if it crashes in 3.2.1 too?

Martijn Versteegh (Baardaap) added a comment.Jul 12 2022, 7:50 PM

Yes, this crash happens in 3.2.1 as well.

Closed by commit rB8e1323f63309: Fix: Move DRW_shgroup_add_material_resources(grp, mat) to after the null-check… (authored by Martijn Versteegh (Baardaap), committed by Clément Foucault (fclem)). · Explain WhyJul 15 2022, 11:22 AM
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) added a commit: rB8e1323f63309: Fix: Move DRW_shgroup_add_material_resources(grp, mat) to after the null-check….
Thomas Dinges (dingto) added a commit: rB7e814d155f25: Fix: Move DRW_shgroup_add_material_resources(grp, mat) to after the null-check….Jul 15 2022, 3:04 PM
Omar Emara (OmarSquircleArt) mentioned this in T99788: Segmentation fault on existing project opening, Apple silicon version on MacOS 12.4.Jul 18 2022, 4:42 PM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
eevee/
3 lines

Diff 53682

View Options

source/blender/draw/engines/eevee/eevee_volumes.c

Loading...