Differential D15445

Fix T99667: Regression in Delete Geometry node
ClosedPublic
Actions

Authored by Wannes Malfait (Wannes) on Jul 13 2022, 3:59 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Maniphest Tasks

T99667: Regression: behavior of Separate/Delete Geometry nodes changed in 3.3

Commits

rB75611838300b: Fix T99667: regression in Delete Geometry node

Summary

This fixes the regression from 3.2 to 3.3, caused by a code refactor.
There is still a bigger bug, T99664, which was present in both versions,
which this does not fix

Diff Detail

Repository

rB Blender

Branch

delete_geo_regression (branched from master)

Build Status

Buildable 22970
Build 22970: arc lint + arc unit

Event Timeline

Wannes Malfait (Wannes) requested review of this revision.Jul 13 2022, 3:59 PM

Wannes Malfait (Wannes) created this revision.

Harbormaster completed remote builds in B22970: Diff 53580.Jul 13 2022, 3:59 PM

Wannes Malfait (Wannes) mentioned this in T99667: Regression: behavior of Separate/Delete Geometry nodes changed in 3.3.Jul 13 2022, 3:59 PM

Wannes Malfait (Wannes) added a task: T99667: Regression: behavior of Separate/Delete Geometry nodes changed in 3.3.

Wannes Malfait (Wannes) added a reviewer: Jacques Lucke (JacquesLucke).

Thanks

This revision is now accepted and ready to land.Jul 13 2022, 5:16 PM

@Jacques Lucke (JacquesLucke) , can you also commit the patch?

Closed by commit rB75611838300b: Fix T99667: regression in Delete Geometry node (authored by Wannes Malfait (Wannes), committed by Jacques Lucke (JacquesLucke)). · Explain WhyJul 20 2022, 3:50 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB75611838300b: Fix T99667: regression in Delete Geometry node.

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_delete_geometry.cc

2 lines

Diff 53580

View Options

source/blender/nodes/geometry/nodes/node_geo_delete_geometry.cc

Fix T99667: Regression in Delete Geometry nodeClosedPublicActions