Fix GPU backend deleting resources without an active context
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jul 15 2022, 1:49 PM.

Details

Reviewers

Jeroen Bakker (jbakker)
Clément Foucault (fclem)

Commits

rB1cf465bbc331: Fix GPU backend deleting resources without an active context

Summary

This causes an assert with libepoxy, but was wrong regardless.

Refactor logic to work as follows:

GPU_exit() deletes backend resources
GPU context create/discard automatically creates/discards the backend
Destroy UI GPU resources with the context active

Ref D15291

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jul 15 2022, 1:49 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B23009: Diff 53686.Jul 15 2022, 1:49 PM

Brecht Van Lommel (brecht) retitled this revision from Fix GPU backend deleting samples without an active context to Fix GPU backend deleting resources without an active context.Jul 15 2022, 1:51 PM

Clément Foucault (fclem) requested changes to this revision.Jul 15 2022, 2:30 PM

Clément Foucault (fclem) added inline comments.

source/blender/gpu/intern/gpu_context.cc
90	this should be guarded by a mutex of some sort. Render threads can create the context themselves AFAIK.

This revision now requires changes to proceed.Jul 15 2022, 2:30 PM

Brecht Van Lommel (brecht) marked an inline comment as done.Jul 15 2022, 2:40 PM

Address comments.

Harbormaster completed remote builds in B23011: Diff 53691.Jul 15 2022, 2:41 PM

Clément Foucault (fclem) accepted this revision.Jul 15 2022, 2:50 PM

This revision is now accepted and ready to land.Jul 15 2022, 2:50 PM

Rebase on D15463.

Expose GPU_backend_exit in the API again. For symmetry I wanted to hide both init and exit, but if init is going to be exposed then we might as well expose exit again also.

Harbormaster completed remote builds in B23014: Diff 53698.Jul 15 2022, 3:57 PM

Brecht Van Lommel (brecht) requested review of this revision.Jul 15 2022, 3:57 PM

Clément Foucault (fclem) accepted this revision.Jul 15 2022, 4:05 PM

This revision is now accepted and ready to land.Jul 15 2022, 4:05 PM

Closed by commit rB1cf465bbc331: Fix GPU backend deleting resources without an active context (authored by Brecht Van Lommel (brecht)). · Explain WhyJul 15 2022, 5:00 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB1cf465bbc331: Fix GPU backend deleting resources without an active context.

Brecht Van Lommel (brecht) mentioned this in rB92a99c149659: Fix Eevee backround render crash after recent changes from D15463.Jul 15 2022, 7:17 PM

Brecht Van Lommel (brecht) mentioned this in D15291: replace GLEW with libepoxy.Jul 15 2022, 8:21 PM