Hi Damien,

That very change was on my never ending to do list. Glad someone got to it!
There was another few additions/changes I was going to get to also. I wrote them down somewhere on my computer but I can't quite find it at the moment.

The biggest one I can remember though was to actually adjust the naming convention to match with rigify. I've had a change of heart and I do think that it is much better to be consistent with the rest of Blender.

I don't know how the reviewing process works but I will download this patch and test everything - but that will most likely be on the weekend.

Thanks for your work!

Take your time!

For review, downloading and testing the patch is indeed the most important part! That, and checking that the new behaviour, code and UI fit in with your vision for the add-on.

Hi Damien,

I seem to be having trouble applying the patch.
I downloaded the raw diff to my source root directory (new git branch)
tried to run the patch command

"patch -p1 > D15471.diff"

Then the terminal just hangs (no output)

I don't know what I've done wrong.

I don’t know how patch works in this context, what I use is:

git apply D15471.diff

It looks like:

patch -p1 < D15471.diff

works as well (the file is passed to the input of patch with a <).

Hi Damien,
The git apply works for me. Great work.

It looks like it is all working as expected although I realise that there probably needs to be a way to disable the DoF on the bone once it has been enabled.
If the user accidentally clicks it, they will need to select the camera and remove the target from there. Pain in the butt.

I don't think this existed in the old version either, but the workaround was to delete the dof_empty (something you could do in the viewport)

Maybe the UI panel should expose the camera focus object (if it exists) so the user can remove it by clicking the X

Looking good Damien.

Let me ping @Brendon Murphy (meta-androcto) to ask him what the proper way is to get this update committed.
Brendon was the one kind enough to commit this initially (I don't have commit rights...for good reason I reckon haha)

I’m not sure Brendon is active in Blender development anymore.

Besides, if you agree with it I can push this myself since I’ve got commit rights for the add-ons repo.

Awesome. About your commit rights that is, not Brendon :(

Commit away - thank you!