Fix T99785: Make Principled Hair IOR input behave like other IOR sliders
ClosedPublic
Actions

Authored by Jesse Yurkovich (deadpin) on Jul 17 2022, 4:51 AM.

Details

Reviewers

Aaron Carlisle (Blendify)
Brecht Van Lommel (brecht)

Maniphest Tasks

T99785: Principled hair BSDF IOR slider inconsistency

Commits

rB22d276a5dce2: Fix T99785: Make Principled Hair IOR input behave like other IOR sliders
rB533a5a6a8c60: Fix T99785: Make Principled Hair IOR input behave like other IOR sliders

Summary

Remove the input slider's PROP_FACTOR subtype in favor of the default to
align with other IOR sliders. This provides much better control when
dragging the value with the mouse.

Diff Detail

Repository: rB Blender

Event Timeline

Jesse Yurkovich (deadpin) requested review of this revision.Jul 17 2022, 4:51 AM

Jesse Yurkovich (deadpin) created this revision.

Harbormaster completed remote builds in B23036: Diff 53743.Jul 17 2022, 4:51 AM

Jesse Yurkovich (deadpin) added a task: T99785: Principled hair BSDF IOR slider inconsistency.Jul 17 2022, 4:51 AM

Jesse Yurkovich (deadpin) added a project: Render & Cycles.Jul 18 2022, 8:32 AM

Change introduced by the Aaron's commit (ed9b21098dd2) so added him as a reviewer

Brecht Van Lommel (brecht) accepted this revision.Jul 18 2022, 6:45 PM

This revision is now accepted and ready to land.Jul 18 2022, 6:45 PM

Closed by commit rB533a5a6a8c60: Fix T99785: Make Principled Hair IOR input behave like other IOR sliders (authored by Jesse Yurkovich (deadpin)). · Explain WhyJul 19 2022, 5:58 AM

This revision was automatically updated to reflect the committed changes.

Jesse Yurkovich (deadpin) added a commit: rB533a5a6a8c60: Fix T99785: Make Principled Hair IOR input behave like other IOR sliders.

Thomas Dinges (dingto) added a commit: rB22d276a5dce2: Fix T99785: Make Principled Hair IOR input behave like other IOR sliders.Jul 20 2022, 3:30 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

shader/

nodes/

node_shader_bsdf_hair_principled.cc

3 lines

Diff 53791

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_hair_principled.cc

Fix T99785: Make Principled Hair IOR input behave like other IOR slidersClosedPublicActions