Page MenuHome

Geometry Nodes: Add Selections to Curve to Mesh Node
Needs ReviewPublic

Authored by Johnny Matthews (guitargeek) on Jul 17 2022, 11:45 PM.
Tokens
"Burninate" token, awarded by Francis_Jasmin."Like" token, awarded by blueprintrandom."Like" token, awarded by AlexeyAdamitsky."Love" token, awarded by lone_noel."Love" token, awarded by Draise."Love" token, awarded by silex."Like" token, awarded by Moder."Love" token, awarded by Dangry.

Details

Summary

Adds boolean selection outputs on the curve to mesh node for easy access:

  • Start Cap
  • End Cap
  • Rail Edges (The edges created from the original input curve duplicated on each profile CV)
  • First Rail Edge (The edge created by the original input curve on the first CV of the profile curve. Useful for creating a useful UV layout for the "tubes" created by this node: ANDing the Cap edges and the first rail edge, a very nice UV unwrap can be accomplished in an easy fashion.
  • Profile Edges (The edged created by the profile curve, duplicated on each original curve CV)

Diff Detail

Repository
rB Blender
Branch
ctm_selections (branched from master)
Build Status
Buildable 23038
Build 23038: arc lint + arc unit

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Jul 17 2022, 11:45 PM
Johnny Matthews (guitargeek) created this revision.
Johnny Matthews (guitargeek) retitled this revision from Geometry Nodes: Add Caps selection to Curve to Mesh to Geometry Nodes: Add Selections to Curve to Mesh Node.Jul 18 2022, 3:12 AM
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)
  • Add First Side Edge, Rails, Profiles
  • Split Start and End Caps
  • Renaming
  • Cleanup

Should the start and end caps return the first and last edge ring even if fill caps is off?

EDIT - I added this as a feature. It seems to make sense.

  • Prevent crash on no points
  • Do edge cap rings if fill caps is off.
Johnny Matthews (guitargeek) planned changes to this revision.Jul 18 2022, 9:38 PM

Add support for Cyclic curves
Optimize some spots

  • Add Cyclic Support
  • Small Optimizations
  • Merge branch 'master' into ctm_selections
  • Update for Attribute Changes

I think at least some of these selections can be build from existing nodes. I see that you're adding these selection outputs for ease of use and that might be fine. But to judge that, we would have to see how complex it would be to build these selection outputs in a node group.
Also it would be nice if you could describe the reasoning for using the terms "rail" and "profile" edges. Might also be fine, but some justification would be good. Are these terms used somewhere else?

I think at least some of these selections can be build from existing nodes.

When there is only one Source curve or Profile Curve this is true, but once you get multiple, possibly with or without end caps, it gets a lot harder.

I see that you're adding these selection outputs for ease of use and that might be fine. But to judge that, we would have to see how complex it would be to build these selection outputs in a node group.

Maybe someone smarter than I can build groups for this that handle the case above (multiple curves on one or both of the input geometries)

Also it would be nice if you could describe the reasoning for using the terms "rail" and "profile" edges. Might also be fine, but some justification would be good. Are these terms used somewhere else?

'Rail' Edges was my own term, the best I could come up with. Representing the Duplicated edges of the original curve. Where "Profile Edges" is the edges that are the duplicated "Profile Curve" input. I'll note that in the description.

I think at least some of these selections can be build from existing nodes. I see that you're adding these selection outputs for ease of use and that might be fine. But to judge that, we would have to see how complex it would be to build these selection outputs in a node group.
Also it would be nice if you could describe the reasoning for using the terms "rail" and "profile" edges. Might also be fine, but some justification would be good. Are these terms used somewhere else?

Those output selection would be quite nice to have I think, for UVs and other effects.
A bit like the extrude node.

Maybe is there was a way to expand/hide some part of a node.
So that it could be hide inside a ''selection output''. As to not clutter a node visually. A bit as what was proposed with the new Principled V2

https://devtalk.blender.org/t/principled-v2-feedback-discussion-thread/24997/117?u=fr002

We talked about this recently in the context of panels in nodes (see D16633). If these were in a collapsible subpanel, I think the UI cost for their addition would be much lower. As it is it's just hard to stomach making the node so much taller.