Page MenuHome
Differential D15482

Update Embree to 3.13.4
ClosedPublic
Actions

Authored by Jason Fielder (jason_apple) on Jul 18 2022, 11:13 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Thomas Dinges (dingto)
Commits
rB757041560f6d: Build: update Embree to 3.13.4, enable Neon2x on Arm
Summary

Embree 3.13.4 allows Apple Silicon machines to use 8-wide BVH.

From embree release notes "Using 8-wide BVH and double pumped NEON instructions on Apple M1 gives 8% performance boost.”

Diff Detail

Repository
rB Blender
Branch
apple/update_embree_3.13.4 (branched from master)
Build Status
Buildable 23041
Build 23041: arc lint + arc unit

Event Timeline

Jason Fielder (jason_apple) requested review of this revision.Jul 18 2022, 11:13 AM
Jason Fielder (jason_apple) created this revision.
Harbormaster completed remote builds in B23040: Diff 53757.Jul 18 2022, 11:13 AM
Thomas Dinges (dingto) requested changes to this revision.Jul 18 2022, 1:55 PM
Thomas Dinges (dingto) added a subscriber: Thomas Dinges (dingto).
Thomas Dinges (dingto) added inline comments.
intern/cycles/bvh/params.h
132

This is just a default initialization for BVHParams(), enabling / disabling this is actually a UI setting. (Performance -> Acceleration Structure panel). Since this was recently disabled per default (rB5f09440d5a6ca914651700c31cd8873fe4e496d0), it can just be changed to false here to match the UI default, but no need for the extra define.

This revision now requires changes to proceed.Jul 18 2022, 1:55 PM
Jason Fielder (jason_apple) updated this revision to Diff 53760.Jul 18 2022, 2:01 PM
  • disable Embree non-compact structures by default
Harbormaster completed remote builds in B23041: Diff 53760.Jul 18 2022, 2:01 PM
Jason Fielder (jason_apple) marked an inline comment as done.Jul 18 2022, 2:02 PM
Thomas Dinges (dingto) accepted this revision.Jul 18 2022, 2:02 PM

Thanks for the quick update. Will leave the remaining part of the review to Brecht.

This revision is now accepted and ready to land.Jul 18 2022, 2:02 PM
Brecht Van Lommel (brecht) accepted this revision.Jul 18 2022, 3:30 PM

I'll combine this with the Windows changes from D15286: Cycles: Integration of path guiding using Intel's Open Path Guiding Library (Open PGL) and commit. I think I can also simplify the Embree patch.

Closed by commit rB757041560f6d: Build: update Embree to 3.13.4, enable Neon2x on Arm (authored by Brecht Van Lommel (brecht)). · Explain WhyJul 18 2022, 3:36 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB757041560f6d: Build: update Embree to 3.13.4, enable Neon2x on Arm.
Brecht Van Lommel (brecht) mentioned this in rBL62974: macOS Arm: update Embree to use Neon2x.Jul 18 2022, 3:42 PM
Brecht Van Lommel (brecht) mentioned this in T98555: Library changes for Blender 3.3.Jul 26 2022, 3:14 PM

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
cmake/
8 lines
4 lines
2 lines
patches/
71 lines
intern/
cycles/
bvh/
2 lines

Diff 53760

View Options

build_files/build_environment/cmake/embree.cmake

Loading...
View Options

build_files/build_environment/cmake/versions.cmake

Loading...
View Options

build_files/build_environment/install_deps.sh

Loading...
View Options

build_files/build_environment/patches/embree.diff

Loading...
View Options

intern/cycles/bvh/params.h

Loading...