Page MenuHome
Differential D15487

Point Cloud: Remove redundant custom data pointers
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jul 19 2022, 3:28 AM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Brecht Van Lommel (brecht)
Maniphest Tasks
T95842: Prepare custom data API for attribute sharing.
Commits
rB410a6efb747f: Point Cloud: Remove redundant custom data pointers
Summary

Similar to D15486, but for point clouds instead.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 19 2022, 3:28 AM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) added a child revision: D14140: Refactor: Const correct Custom Data API, prepare for CoW.Jul 19 2022, 3:32 AM
Hans Goudey (HooglyBoogly) added a task: T95842: Prepare custom data API for attribute sharing..Jul 19 2022, 3:56 AM
Hans Goudey (HooglyBoogly) updated this revision to Diff 53817.Jul 19 2022, 6:56 PM

Update cycles and convex hull node

Hans Goudey (HooglyBoogly) added a comment.Jul 19 2022, 6:58 PM

https://builder.blender.org/admin/#/builders/18/builds/542

Hans Goudey (HooglyBoogly) added reviewers: Jacques Lucke (JacquesLucke), Brecht Van Lommel (brecht).Jul 19 2022, 7:37 PM
Brecht Van Lommel (brecht) accepted this revision.Jul 19 2022, 7:41 PM
This revision is now accepted and ready to land.Jul 19 2022, 7:41 PM
Jacques Lucke (JacquesLucke) accepted this revision.Jul 19 2022, 10:27 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/intern/pointcloud.cc
199

This is missing calls to finish in multiple places. Should add back debugging functionality to check for this.

Hans Goudey (HooglyBoogly) marked an inline comment as done.Jul 20 2022, 1:03 AM
Closed by commit rB410a6efb747f: Point Cloud: Remove redundant custom data pointers (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJul 20 2022, 1:16 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB410a6efb747f: Point Cloud: Remove redundant custom data pointers.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
1 line
intern/
11 lines
5 lines
19 lines
45 lines
draw/
intern/
13 lines
geometry/
intern/
14 lines
21 lines
makesdna/
6 lines
makesrna/
intern/
48 lines
nodes/
geometry/
nodes/
11 lines
20 lines
19 lines

Diff 53788

View Options

source/blender/blenkernel/BKE_pointcloud.h

Loading...
View Options

source/blender/blenkernel/intern/bvhutils.cc

Loading...
View Options

source/blender/blenkernel/intern/geometry_component_pointcloud.cc

Loading...
View Options

source/blender/blenkernel/intern/mesh_convert.cc

Loading...
View Options

source/blender/blenkernel/intern/pointcloud.cc

Loading...
View Options

source/blender/draw/intern/draw_cache_impl_pointcloud.c

Loading...
View Options

source/blender/geometry/intern/point_merge_by_distance.cc

Loading...
View Options

source/blender/geometry/intern/realize_instances.cc

Loading...
View Options

source/blender/makesdna/DNA_pointcloud_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_pointcloud.c

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_distribute_points_on_faces.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_instances_to_points.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_transform.cc

Loading...