Fix T99732 : FCURVESONLY filter in Grease Pencil dopesheet
ClosedPublic
Actions

Authored by Amelie Fondevilla (afonde) on Jul 19 2022, 10:53 AM.

Details

Reviewers

Falk David (filedescriptor)
Antonio Vazquez (antoniov)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T99732: Regression: Crash when opening the F3 menu in the dopesheet

Commits

rB801513efa068: Fix T99732: Crash on F3 in the dopesheet

Summary

Fix T99732
Adding the FCURVESONLY filter in the filter function of the Grease Pencil dopesheet prevents calls to F-curves related functions to grease pencil channels.

Diff Detail

Repository: rB Blender

Event Timeline

Amelie Fondevilla (afonde) requested review of this revision.Jul 19 2022, 10:53 AM

Amelie Fondevilla (afonde) created this revision.

Harbormaster completed remote builds in B23057: Diff 53793.Jul 19 2022, 10:53 AM

Amelie Fondevilla (afonde) retitled this revision from Fix T99732 : Adding the FCURVESONLY filter in the filter function of the Grease Pencil dopesheet prevents calls to F-curves related functions to grease pencil channels. to Fix T99732 : FCURVESONLY filter in Grease Pencil dopesheet.Jul 19 2022, 10:54 AM

Amelie Fondevilla (afonde) edited the summary of this revision. (Show Details)

Amelie Fondevilla (afonde) added a task: T99732: Regression: Crash when opening the F3 menu in the dopesheet.

This seems to fix the issue : blender no longer crashes when typing F3 in grease pencil dopesheet.
However, I am not 100% sure if this is the right place to put this if filtering condition, as I don't know what cases the if condition above (line 1802) covers. Maybe the filtering condition should be added before that.

Antonio Vazquez (antoniov) added reviewers: Falk David (filedescriptor), Antonio Vazquez (antoniov).Jul 19 2022, 11:17 AM

Antonio Vazquez (antoniov) added a reviewer: Sybren A. Stüvel (sybren).

LGTM

I have tested and the crash has gone.

@Sybren A. Stüvel (sybren) Do you think the fix is ok? If you agree, we can solve this high priority bug.

This revision is now accepted and ready to land.Jul 19 2022, 11:56 AM

LGTM!

Closed by commit rB801513efa068: Fix T99732: Crash on F3 in the dopesheet (authored by Amélie Fondevilla <afonde>, committed by Sybren A. Stüvel (sybren)). · Explain WhyJul 19 2022, 5:51 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rB801513efa068: Fix T99732: Crash on F3 in the dopesheet.