Details

Reviewers

Commits

rB98bf714b37c1: Refactor: arrange transform convert functions in 'TransConvertTypeInfo'

Summary

Simplify the transform code by bundling the TransData creation, Data
recalculation, and special updates into a single struct.

So similar functions and parameters can be accessed without special
type checks.

The Transform code has an extensive list of Data types.

This list keeps growing (rBd14c2d549b2f) and with it, enums and
specific conditions are added to various scattered parts of the code,
making it complicated.

So it's good to conventionalize types and functions.

Later more members can be added to the struct:

create/free Data allocated specifically for the type
create/free Data for snapping
Function for calculating proportional editing factors

And others

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Jul 19 2022, 7:19 PM

Germano Cavalcante (mano-wii) created this revision.

Harbormaster completed remote builds in B23064: Diff 53819.Jul 19 2022, 7:19 PM

Fix comments

Harbormaster completed remote builds in B23065: Diff 53820.Jul 19 2022, 7:22 PM

Remove wrong usage of the UNUSED macro

Harbormaster completed remote builds in B23066: Diff 53821.Jul 19 2022, 7:24 PM

Avoid referencing NULL pointer

Harbormaster completed remote builds in B23067: Diff 53822.Jul 19 2022, 7:29 PM

This seems reasonable however this patch causes transform not to refresh contents while transforming, tested on Linux (finishing transform redraws as expected). Tested with object-mode/mesh-edit-mode and UV editing.

source/blender/editors/transform/transform_convert_action.c
934	This function can now be declared `static`.

This revision now requires changes to proceed.Jul 22 2022, 4:40 AM

fix recalData failure (caused by last unchecked change)
silence warning

Harbormaster completed remote builds in B23105: Diff 53927.Jul 22 2022, 4:57 AM

Germano Cavalcante (mano-wii) marked an inline comment as done.Jul 22 2022, 4:58 AM

Looks good, note that some of the ELEM(..) checks would be good to replace with a capabilities flag, for PET, Multi-object editing... etc.

This revision is now accepted and ready to land.Jul 22 2022, 7:19 AM

Closed by commit rB98bf714b37c1: Refactor: arrange transform convert functions in 'TransConvertTypeInfo' (authored by Germano Cavalcante (mano-wii)). · Explain WhyJul 22 2022, 3:01 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rB98bf714b37c1: Refactor: arrange transform convert functions in 'TransConvertTypeInfo'.

Refactor: arrange transform convert functions in 'TransConvertTypeInfo'
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 53933

source/blender/editors/transform/transform.h

source/blender/editors/transform/transform.c

source/blender/editors/transform/transform_convert.h

source/blender/editors/transform/transform_convert.c

source/blender/editors/transform/transform_convert_action.c

source/blender/editors/transform/transform_convert_armature.c

source/blender/editors/transform/transform_convert_cursor.c

source/blender/editors/transform/transform_convert_curve.c

source/blender/editors/transform/transform_convert_gpencil.c

source/blender/editors/transform/transform_convert_graph.c

source/blender/editors/transform/transform_convert_lattice.c

source/blender/editors/transform/transform_convert_mask.c

source/blender/editors/transform/transform_convert_mball.c

source/blender/editors/transform/transform_convert_mesh.c

source/blender/editors/transform/transform_convert_mesh_edge.c

source/blender/editors/transform/transform_convert_mesh_skin.c

source/blender/editors/transform/transform_convert_mesh_uv.c

source/blender/editors/transform/transform_convert_mesh_vert_cdata.c

source/blender/editors/transform/transform_convert_nla.c

source/blender/editors/transform/transform_convert_node.c

source/blender/editors/transform/transform_convert_object.c

source/blender/editors/transform/transform_convert_object_texspace.c

source/blender/editors/transform/transform_convert_paintcurve.c

source/blender/editors/transform/transform_convert_particle.c

source/blender/editors/transform/transform_convert_sculpt.c

source/blender/editors/transform/transform_convert_sequencer.c

source/blender/editors/transform/transform_convert_sequencer_image.c

source/blender/editors/transform/transform_convert_tracking.c

source/blender/editors/transform/transform_mode.c

source/blender/editors/transform/transform_snap.c

source/blender/editors/transform/transform_snap_sequencer.c

Refactor: arrange transform convert functions in 'TransConvertTypeInfo'ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53933

source/blender/editors/transform/transform.h

source/blender/editors/transform/transform.c

source/blender/editors/transform/transform_convert.h

source/blender/editors/transform/transform_convert.c

source/blender/editors/transform/transform_convert_action.c

source/blender/editors/transform/transform_convert_armature.c

source/blender/editors/transform/transform_convert_cursor.c

source/blender/editors/transform/transform_convert_curve.c

source/blender/editors/transform/transform_convert_gpencil.c

source/blender/editors/transform/transform_convert_graph.c

source/blender/editors/transform/transform_convert_lattice.c

source/blender/editors/transform/transform_convert_mask.c

source/blender/editors/transform/transform_convert_mball.c

source/blender/editors/transform/transform_convert_mesh.c

source/blender/editors/transform/transform_convert_mesh_edge.c

source/blender/editors/transform/transform_convert_mesh_skin.c

source/blender/editors/transform/transform_convert_mesh_uv.c

source/blender/editors/transform/transform_convert_mesh_vert_cdata.c

source/blender/editors/transform/transform_convert_nla.c

source/blender/editors/transform/transform_convert_node.c

source/blender/editors/transform/transform_convert_object.c

source/blender/editors/transform/transform_convert_object_texspace.c

source/blender/editors/transform/transform_convert_paintcurve.c

source/blender/editors/transform/transform_convert_particle.c

source/blender/editors/transform/transform_convert_sculpt.c

source/blender/editors/transform/transform_convert_sequencer.c

source/blender/editors/transform/transform_convert_sequencer_image.c

source/blender/editors/transform/transform_convert_tracking.c

source/blender/editors/transform/transform_mode.c

source/blender/editors/transform/transform_snap.c

source/blender/editors/transform/transform_snap_sequencer.c

Refactor: arrange transform convert functions in 'TransConvertTypeInfo'
ClosedPublic
Actions

Revision Contents
Changeset List