Page MenuHome
Differential D15500

Geometry Nodes: fix Store Named Attribute for vertex groups.
AbandonedPublic
Actions

Authored by Alexander Gavrilov (angavrilov) on Jul 20 2022, 2:21 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T99873: Store/Remove Named Attribute issues with vertex groups
Summary

For some reason the evaluation code for this node starts with
deleting the attribute, which destroys its Vertex Group status
and the data is written as an abstract custom attribute. It is
much more logical to first try writing to the existing attribute.

Diff Detail

Repository
rB Blender
Branch
temp-angavrilov-geonode-store-vg (branched from master)
Build Status
Buildable 23077
Build 23077: arc lint + arc unit

Event Timeline

Alexander Gavrilov (angavrilov) requested review of this revision.Jul 20 2022, 2:21 PM
Alexander Gavrilov (angavrilov) created this revision.
Harbormaster completed remote builds in B23077: Diff 53862.Jul 20 2022, 2:21 PM
Alexander Gavrilov (angavrilov) added a task: T99873: Store/Remove Named Attribute issues with vertex groups.Jul 20 2022, 2:22 PM
Alexander Gavrilov (angavrilov) added a reviewer: Hans Goudey (HooglyBoogly).

Note that I only tested this with the vertex groups, so can't guarantee there are no negative side effects in other areas. This also doesn't address the removal issues from the bug report.

Hans Goudey (HooglyBoogly) abandoned this revision.Jul 21 2022, 11:26 PM

Thanks for the patch. I looked into solving this part of the problem a bit differently though, just to make the logic a bit clearer: D15514

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
23 lines

Diff 53862

View Options

source/blender/nodes/geometry/nodes/node_geo_store_named_attribute.cc

Loading...