Page MenuHome
Differential D15505

Fix Unreported : add F-curves only filter to functions only appliable to F-curves channels.
ClosedPublic
Actions

Authored by Amelie Fondevilla (afonde) on Jul 20 2022, 2:45 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Commits
rBfdf34666f00f: Fix Unreported : add F-curves only filter to functions only appliable to F…
Summary

The filter was missing in some places that are using channel data as if it was fcurve channel.
There seems to be no related issue or bug, but still it would be best to have them there.

Diff Detail

Repository
rB Blender

Event Timeline

Amelie Fondevilla (afonde) requested review of this revision.Jul 20 2022, 2:45 PM
Amelie Fondevilla (afonde) created this revision.
Harbormaster completed remote builds in B23080: Diff 53867.Jul 20 2022, 2:45 PM
Amelie Fondevilla (afonde) edited the summary of this revision. (Show Details)Jul 20 2022, 2:53 PM
Pratik Borhade (PratikPB2123) added a reviewer: Sybren A. Stüvel (sybren).Jul 23 2022, 6:40 AM
Sybren A. Stüvel (sybren) accepted this revision.Jul 26 2022, 4:11 PM

I love how /* curves only */ comments are replaced with ANIMFILTER_FCURVESONLY code :)

This revision is now accepted and ready to land.Jul 26 2022, 4:11 PM
Amelie Fondevilla (afonde) updated this revision to Diff 54078.Jul 26 2022, 5:58 PM
  • use ENUM_OPERATORS to avoid an insane cast
Harbormaster completed remote builds in B23169: Diff 54078.Jul 26 2022, 5:58 PM
Amelie Fondevilla (afonde) updated this revision to Diff 54094.EditedJul 27 2022, 10:17 AM
  • use ENUM_OPERATORS to avoid an insane cast (minor but essential fix)
Harbormaster completed remote builds in B23174: Diff 54094.Jul 27 2022, 10:17 AM
Sybren A. Stüvel (sybren) added a comment.Aug 2 2022, 11:44 AM

👍 on the ENUM_OPERATORS :)

Closed by commit rBfdf34666f00f: Fix Unreported : add F-curves only filter to functions only appliable to F… (authored by Amelie Fondevilla (afonde)). · Explain WhyAug 2 2022, 12:39 PM
This revision was automatically updated to reflect the committed changes.
Amelie Fondevilla (afonde) added a commit: rBfdf34666f00f: Fix Unreported : add F-curves only filter to functions only appliable to F….

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
animation/
10 lines
4 lines
7 lines
include/
1 line
space_graph/
2 lines

Diff 54299

View Options

source/blender/editors/animation/anim_channels_edit.c

Loading...
View Options

source/blender/editors/animation/keyframes_edit.c

Loading...
View Options

source/blender/editors/animation/keyframes_keylist.cc

Loading...
View Options

source/blender/editors/include/ED_anim_api.h

Loading...
View Options

source/blender/editors/space_graph/space_graph.c

Loading...