Fix T99880: Passing Span<bNode *> in to node_get_execution_time to eval current node tree level
AbandonedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Jul 21 2022, 2:29 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T99880: No node timing for frames inside groups

Summary

Now the calculation of the frame nodes
occurs with the using const bNodeTree &ntree.
But it contains only the top level of the tree, which
is why more levels than first nodes of the frame is not
taken into account. This patch replaces it with a
visible node level span, which fixes the bug.

Bugfix:

Report:
https://developer.blender.org/T99880

Diff Detail

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Jul 21 2022, 2:29 PM

Iliya Katueshenock (Moder) created this revision.

Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)

Iliya Katueshenock (Moder) retitled this revision from Fix T99880: Passing in node_get_execution_time Span<bNode *> to traverse current node tree level to Fix T99880: Passing in node_get_execution_time Span<bNode *> to eval current node tree level.Jul 21 2022, 2:33 PM

Iliya Katueshenock (Moder) retitled this revision from Fix T99880: Passing in node_get_execution_time Span<bNode *> to eval current node tree level to Fix T99880: Passing Span<bNode *> in node_get_execution_time to eval current node tree level.Jul 21 2022, 5:16 PM

Iliya Katueshenock (Moder) retitled this revision from Fix T99880: Passing Span<bNode *> in node_get_execution_time to eval current node tree level to Fix T99880: Passing Span<bNode *> in to node_get_execution_time to eval current node tree level.

Pratik Borhade (PratikPB2123) added a task: T99880: No node timing for frames inside groups.Jul 21 2022, 5:21 PM

Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)Jul 21 2022, 5:22 PM

Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)

Iliya Katueshenock (Moder) removed a reviewer: Erik Abrahamsson (erik85).Jul 21 2022, 6:55 PM

Iliya Katueshenock (Moder) abandoned this revision.Jul 25 2022, 1:12 PM