Fix T99873: Store named attribute node cannot write to vertex groups
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jul 21 2022, 11:25 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Maniphest Tasks

T99873: Store/Remove Named Attribute issues with vertex groups

Commits

rBc40971d79a88: Fix T99873: Store named attribute node cannot write to vertex groups

Summary

Since fd5e5dac8946b13599, the node would remove the attribute before
adding it again, which lost the vertex group status of an attribute,
meaning they were written as arbitrary attributes.

Now, the node first tries to write to attributes with the same domain
and data-type, which covers the vertex group case. Then it falls back
to removing the attribute and adding it again. Even that can fail
though, so I added an error message to make that a bit clearer.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 21 2022, 11:25 PM

Hans Goudey (HooglyBoogly) created this revision.

Hans Goudey (HooglyBoogly) added a task: T99873: Store/Remove Named Attribute issues with vertex groups.

Hans Goudey (HooglyBoogly) mentioned this in D15500: Geometry Nodes: fix Store Named Attribute for vertex groups..

Alexander Gavrilov (angavrilov) added a subscriber: Alexander Gavrilov (angavrilov).Jul 22 2022, 1:46 PM

Alexander Gavrilov (angavrilov) added inline comments.

source/blender/nodes/geometry/nodes/node_geo_store_named_attribute.cc
117	The previous code seems to check domain and type after lookup_for_write, and also checks write_attribute for null. So I wonder if it is really necessary to do separate lookup_meta_data, and whether something might crash if lookup_for_write somehow failed. But I have no clue about this code, this is just observations from this diff alone.