Page MenuHome

Fix T99873: Use evaluated vertex groups in armature modifier
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jul 22 2022, 12:49 AM.

Details

Summary

Geometry nodes has added the ability to modify mesh vertex groups
during evaluation (see 3b6ee8cee7080af2). However, the armature
modifier always uses the vertex groups from the original object.
This is wrong for the modifier stack, where each modifier is meant
to use the output of the previous.

This commit makes the armature modifier use the evaluated vertex groups
if they are available. Otherwise it uses the originals like before.

Diff Detail

Repository
rB Blender

Event Timeline

Seems ok, could only find naming and formatting nitpicks. Maybe ask somebody who originally wrote this just in case?

source/blender/blenkernel/intern/armature_deform.c
486

Maybe call it target_data_id to be clear?

511

Add a newline and a comment here maybe?

This revision is now accepted and ready to land.Jul 22 2022, 6:51 PM
Hans Goudey (HooglyBoogly) marked 2 inline comments as done.Jul 22 2022, 10:50 PM