Fix divide my zero error in fbx import
ClosedPublic
Actions

Authored by Julian (joolsa) on Oct 12 2015, 6:19 PM.

Details

Reviewers

Commits

rBA7ef985757de5: Fix error in case FBX file specifies no known pre-defined FPS and a null…

Summary

(Present in Blender 2.76). On loading an FBX file the import failed due to a divide by zero error. This one character patch extends the code which set a default frame rate if a negative frame-rate was in the FBX file to also set the default frame-rate if zero was in the FBX file.

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Julian (joolsa) updated this revision to Diff 5165.Oct 12 2015, 6:19 PM

Julian (joolsa) retitled this revision from to Fix divide my zero error in fbx import.

Julian (joolsa) updated this object.

Julian (joolsa) set the repository for this revision to rBA Blender Add-ons.

Eeeeh… yes, that patch is fine as security measure, but I think it should never get 0.0 here… Can I have the FBX file that generated such error?

Bastien Montagne (mont29) added a reviewer: Bastien Montagne (mont29).Oct 13 2015, 11:50 AM

Hi Bastien -

I talked to the artist and as the content is licensed I can't upload it here :( I do know it was exported from Modo. We tried creating a cube and exporting that as an FBX however that didn't give the same issue. Nonetheless it would be helpful for me if you were able to commit the patch. As you say it could also be a security issue.

Thanks,

Jools

I’ll commit it later today.

As for the file, in case it’d be possible, you could share it privately somewhere and send me private access data to b.mont29@gmail.com (or even directly invite that account in case you upload on googledrive).

Closed by commit rBA7ef985757de5: Fix error in case FBX file specifies no known pre-defined FPS and a null… (authored by Bastien Montagne (mont29)). · Explain WhyOct 13 2015, 6:04 PM

This revision was automatically updated to reflect the committed changes.