Fix T99816: Adds Blank and Duplicate Check for Rename Attribute
AbandonedPublic
Actions

Authored by Arye Ramaty (BelgaratTheGrey) on Jul 23 2022, 9:38 PM.

Details

Reviewers: None
Maniphest Tasks: T99816: Renaming Atrribute in the data panel does not accont for using the original name or a blank space.

Summary

There wasn't any check for empty strings in the rename function of attributes which caused a crash.
This patch doesn't execute the rename function If the new name is empty or if it is the same as the old one.

P.S.
I am not sure I did the submission correctly, anyway this is my bug report:
https://developer.blender.org/T99816

Diff Detail

Repository

rB Blender

Branch

rename_attribute_fix (branched from master)

Build Status

Buildable 23122
Build 23122: arc lint + arc unit

Event Timeline

Arye Ramaty (BelgaratTheGrey) requested review of this revision.Jul 23 2022, 9:38 PM

Arye Ramaty (BelgaratTheGrey) created this revision.

Harbormaster completed remote builds in B23122: Diff 53963.Jul 23 2022, 9:38 PM

Arye Ramaty (BelgaratTheGrey) retitled this revision from Fix attribute blank rename crash to Fix T99816: Adds Blank and Duplicate Check for Rename Attribute.Jul 23 2022, 9:43 PM

Arye Ramaty (BelgaratTheGrey) edited the summary of this revision. (Show Details)

Arye Ramaty (BelgaratTheGrey) edited the summary of this revision. (Show Details)Jul 23 2022, 9:50 PM

Iliya Katueshenock (Moder) added a task: T99816: Renaming Atrribute in the data panel does not accont for using the original name or a blank space..Jul 23 2022, 10:03 PM

Arye Ramaty (BelgaratTheGrey) added a project: Geometry Nodes.Jul 24 2022, 1:06 PM