Page MenuHome
Differential D15562

A Fix \ papercut for blank space in renaming shapekeys
AbandonedPublic
Actions

Authored by Arye Ramaty (BelgaratTheGrey) on Jul 28 2022, 3:38 PM.

Details

Reviewers
None
Summary

If you put a blank space while renaming a shape key, the name would increment strangely instead of canceling the operation.

master:

patch:

Diff Detail

Repository
rB Blender
Branch
shapekey_blank_rename_fix (branched from master)
Build Status
Buildable 23193
Build 23193: arc lint + arc unit

Event Timeline

Arye Ramaty (BelgaratTheGrey) requested review of this revision.Jul 28 2022, 3:38 PM
Arye Ramaty (BelgaratTheGrey) created this revision.
Harbormaster completed remote builds in B23193: Diff 54138.Jul 28 2022, 3:38 PM
Arye Ramaty (BelgaratTheGrey) edited the summary of this revision. (Show Details)Jul 28 2022, 3:42 PM
Arye Ramaty (BelgaratTheGrey) added projects: User Interface, Restricted Project.
Arye Ramaty (BelgaratTheGrey) edited the summary of this revision. (Show Details)
Campbell Barton (campbellbarton) abandoned this revision.Jul 29 2022, 8:20 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

Prefer to keep the current functionality as a blank string is used to pick the default name for many other kinds of data (objects, meshes etc).

If you propose different behavior this should be handled as a design task first.

Arye Ramaty (BelgaratTheGrey) added a comment.Jul 29 2022, 12:04 PM

Fair enough

Revision Contents
Changeset List

PathSize
source/
blender/
makesrna/
intern/
5 lines

Diff 54138

View Options

source/blender/makesrna/intern/rna_key.c

Loading...