Affected by rB8621fdb10dc4
Crash if single-user data is created when we apply transform
on multi-user image data. Crash occurs because creation of new copy
was not handled in single_obdata_users for empty objects (image for example)
Details
Details
- Reviewers
Dalai Felinto (dfelinto) Bastien Montagne (mont29) - Maniphest Tasks
- T100040: Crash with rescaling reference image and apply scale
- Commits
- rB80d193c51b46: Fix T100040: Crash when transform applied on multi-user image
rB3e8bd1f6e479: Fix T100040: Crash when transform applied on multi-user image
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
I think it seems about right. I would like to consult with Bastien here though.
By the way, apply transform is not working well (in master) for image objects. While applying scale works:
- If we apply rotation it shouldn't do anything (right now it reset to (0,0,0).
- If we apply location it shouldn't do anything (right now it set to 0,0,0) OR it should change the image offset.
Comment Actions
@Dalai Felinto (dfelinto) , thanks for reviewing the patch :)
, apply transform is not working well (in master) for image objects
Yes but that's different issue Apply transform for empties has been working like this for long time (2.93 is the oldest version I checked and broken too)
Not only location and rotation, Apply scale is affected too (if we change scale along particular axis)
Comment Actions
- If we apply rotation it shouldn't do anything (right now it reset to (0,0,0).
- If we apply location it shouldn't do anything (right now it set to 0,0,0) OR it should change the image offset.
@Dalai Felinto (dfelinto) , apply transforms are not implemented yet for rotation and location: https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/object/object_transform.cc$947