Differential D15601

Fix T100093 : Channel selection and grouping in Graph Editor
ClosedPublic
Actions

Authored by Amelie Fondevilla (afonde) on Aug 2 2022, 11:24 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Maniphest Tasks

T100093: Regression: Can't select graph editor channels and grouping them together crashes Blender

Commits

rB45f483681fef: Fix T100093: Channel selection and grouping issues

Summary

Fixing T100093
Channel selection in graph editor was broken by rB3c5620aabd33 because the selection took into account grease pencil channels. Such channels are now removed from selection in containers that does not use them (NLA and Graph Editor).
Grouping was broken from a similar issue. The grouping operation now completely filters out grease pencil channels since the operator is only defined for f-curve channels.

Diff Detail

Repository

rB Blender

Branch

fix-graph-editor-select (branched from master)

Build Status

Buildable 23238
Build 23238: arc lint + arc unit

Event Timeline

Amelie Fondevilla (afonde) requested review of this revision.Aug 2 2022, 11:24 AM

Amelie Fondevilla (afonde) created this revision.

Harbormaster completed remote builds in B23235: Diff 54296.Aug 2 2022, 11:24 AM

Amelie Fondevilla (afonde) retitled this revision from fixing channel selection in graph editor to Fix T100093 : Channel selection and grouping in Graph Editor.Aug 2 2022, 11:31 AM

Amelie Fondevilla (afonde) edited the summary of this revision. (Show Details)

Amelie Fondevilla (afonde) added a reviewer: Sybren A. Stüvel (sybren).

rebase blender-v3.3-release
It did not work as expected, the arc diff added a commit that is in both blender-v3.3-release and master branch.
I'll try to clean the diff..

Harbormaster completed remote builds in B23237: Diff 54302.Aug 2 2022, 12:42 PM

Pratik Borhade (PratikPB2123) added a task: T100093: Regression: Can't select graph editor channels and grouping them together crashes Blender.Aug 2 2022, 12:56 PM

rebase master

Harbormaster completed remote builds in B23238: Diff 54306.Aug 2 2022, 2:39 PM

LGTM!

This revision is now accepted and ready to land.Aug 4 2022, 6:36 PM

Closed by commit rB45f483681fef: Fix T100093: Channel selection and grouping issues (authored by Amelie Fondevilla (afonde), committed by Sybren A. Stüvel (sybren)). · Explain WhyAug 5 2022, 12:09 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rB45f483681fef: Fix T100093: Channel selection and grouping issues.